On Mon, 30 May 2011, Tomas 'ebik' Ebenlendr wrote:

> Package: zip
> Version: 3.0-3
> Severity: normal
> Tags: patch
> 
> Zipnote fails to update archive. The fail is caused by fclose(x), where 'x'
> is either undefined or already closed. Simple patch follows.
> 
> --- zipnote.c   2008-05-08 10:17:08.000000000 +0200
> +++ zipnote-patched.c   2011-05-30 16:10:40.000000000 +0200
> @@ -661,7 +661,6 @@
>      if ((r = zipcopy(z)) != ZE_OK)
>        ziperr(r, "was copying an entry");
>    }
> -  fclose(x);

Thanks a lot for the report.

This bug was introduced in version 3.0, and I see that it's fixed in
the latest beta version with this changelog entry:

 4. Fix bug in zipnote where undefined file x was being closed instead of
    in_file.  zipnote.c (Christian)

and this patch:

@@ -661,7 +661,7 @@
     if ((r = zipcopy(z)) != ZE_OK)
       ziperr(r, "was copying an entry");
   }
-  fclose(x);
+  fclose(in_file);
 
   /* Write central directory and end of central directory with new comments */
   if ((c = zftello(y)) == (zoff_t)-1)    /* get start of central */


so I'll do that in the next upload.



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to