Package: graphviz
Version: 2.26.3-5
Severity: normal
User: [email protected]
Usertags: no-add-needed
With a linker defaulting to --no-copy-dt-needed-entries
(http://wiki.debian.org/ToolChain/DSOLinking), graphviz fails to build,
for example:
https://launchpadlibrarian.net/71264605/buildlog_ubuntu-oneiric-i386.graphviz_2.26.3-5ubuntu2_FAILEDTOBUILD.txt.gz
make[4]: Entering directory `/build/buildd/graphviz-2.26.3/cmd/dot'
CC dot-dot.o
CC dot-no_builtins.o
CCLD dot
/usr/bin/ld: dot-dot.o: undefined reference to symbol 'agsetiodisc'
/usr/bin/ld: note: 'agsetiodisc' is defined in DSO
/build/buildd/graphviz-2.26.3/lib/graph/.libs/libgraph.so.4 so try adding it to
the linker command line
/build/buildd/graphviz-2.26.3/lib/graph/.libs/libgraph.so.4: could not read
symbols: Invalid operation
collect2: ld returned 1 exit status
The attached patch fixes this, although review would be welcome as I
don't know graphviz especially well.
Thanks,
--
Colin Watson [[email protected]]
Index: b/cmd/dot/Makefile.am
===================================================================
--- a/cmd/dot/Makefile.am
+++ b/cmd/dot/Makefile.am
@@ -54,7 +54,7 @@
dot_SOURCES = dot.c no_builtins.c
dot_CPPFLAGS = $(AM_CPPFLAGS) -DDEMAND_LOADING=1
-dot_LDADD = $(top_builddir)/lib/gvc/libgvc.la
+dot_LDADD = $(top_builddir)/lib/gvc/libgvc.la
$(top_builddir)/lib/$(GRAPH)/lib$(GRAPH).la
install-data-hook:
(cd $(DESTDIR)$(man1dir); for i in $(linkedman); do rm -f $$i; $(LN_S)
dot.1 $$i; done;)
Index: b/cmd/tools/Makefile.am
===================================================================
--- a/cmd/tools/Makefile.am
+++ b/cmd/tools/Makefile.am
@@ -47,7 +47,8 @@
gxl2gv_LDADD = \
$(top_builddir)/lib/ingraphs/libingraphs_C.la \
- $(top_builddir)/lib/cgraph/libcgraph.la @EXPAT_LIBS@
+ $(top_builddir)/lib/cgraph/libcgraph.la \
+ $(top_builddir)/lib/cdt/libcdt.la @EXPAT_LIBS@
gxl2gv.1.pdf: $(srcdir)/gxl2gv.1
- @GROFF@ -Tps -man $(srcdir)/gxl2gv.1 | @PS2PDF@ - - >gxl2gv.1.pdf
@@ -139,6 +140,8 @@
gvpack_LDADD = \
$(top_builddir)/lib/gvc/libgvc.la \
$(top_builddir)/lib/ingraphs/libingraphs_C.la \
+ $(top_builddir)/lib/graph/libgraph.la \
+ $(top_builddir)/lib/cdt/libcdt.la \
$(top_builddir)/plugin/neato_layout/libgvplugin_neato_layout.la
gvpack.1.pdf: $(srcdir)/gvpack.1
@@ -175,7 +178,8 @@
rm @[email protected]
gml2gv_LDADD = \
- $(top_builddir)/lib/cgraph/libcgraph.la @MATH_LIBS@
+ $(top_builddir)/lib/cgraph/libcgraph.la \
+ $(top_builddir)/lib/cdt/libcdt.la @MATH_LIBS@
gml2gv.1.pdf: gml2gv.1
- @GROFF@ -Tps -man gml2gv.1 | @PS2PDF@ - - >gml2gv.1.pdf
@@ -184,7 +188,8 @@
dijkstra_LDADD = \
$(top_builddir)/lib/ingraphs/libingraphs_C.la \
- $(top_builddir)/lib/cgraph/libcgraph.la
+ $(top_builddir)/lib/cgraph/libcgraph.la \
+ $(top_builddir)/lib/cdt/libcdt.la
dijkstra.1.pdf: $(srcdir)/dijkstra.1
- @GROFF@ -Tps -man $(srcdir)/dijkstra.1 | @PS2PDF@ - - >dijkstra.1.pdf
