Hi Bastien, On Tue, Apr 05, 2011 at 03:48:09PM +0200, Bastien ROUCARIES wrote: > Package: gitpkg > Version: 0.18 > Severity: normal > > Create a package with version 2.3.0~r29173-1 and try to export it using quilt > patch export will not work. > > Git disalllow ~ in tag or branch. Therefore gitpkg should transform ~ to _ > internally before creating patch
Sorry for the slow reply, we've been pondering this one for a few days, because it's not quite so simple as just transforming ~ to _, since there there are a number of illegal constructs, and there is no actual standard for remapping them that we know everyone is using. One of the aims of gitpkg is that it should be able to extract a working source package from pretty much any sane git repository, without having to arrange that repo in some specific form beforehand. So it's fairly important that we can cater for people who chose a different mapping too. The hooks, by nature, can imply additional constraints, but I'd still like to keep this as flexible as possible where we can. What it looks like we'll probably do for now is use the sanitise_git_ref function (currently only in the git-debimport script), and then get the quilt hook to export {DEB,UPSTREAM}_REF mangled with it (which basically does what you are asking for, replaces all chains of illegals with a single '_'). For now the way to override the mapping will be to replace that function with one that does the mapping of your choosing. If we find that people really do need a different mapping (or several of them), then we can have a look at making that a little more user-friendly once we have an idea of what alternate mappings really do exist. There should be a new package uploaded with this change fairly soon. Cheers, Ron -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org