Subject: org-mode: Cannot Store Org-Links from DocView Mode
Package: org-mode
Version: 7.4-2
Severity: normal
Tags: patch
*** Please type your report below this line ***
Trying to store a link to a PDF file with Squeeze's org-mode causes
org-mode to error instead of storing the link.
Sid's version works fine!
** Reproducing
0. Install the emacs and org-mode packages from Squeeze.
1. Start emacs:
emacs -Q
2. Open a PDF.
3. Store a link to the PDF:
M-x org-store-link
4. Watch it error:
org-docview-store-link: Invalid function: doc-view-current-page
** Resolving
1. Install org-mode from Unstable.
** Patch
Attached. :)
--- org-docview.el 2010-07-21 11:42:48.000000000 -0500
+++ /usr/share/emacs/site-lisp/org-mode/org-docview.el 2011-01-06 09:17:18.000000000 -0600
@@ -5,7 +5,7 @@
;; Author: Jan Böcker <jan.boecker at jboecker dot de>
;; Keywords: outlines, hypermedia, calendar, wp
;; Homepage: http://orgmode.org
-;; Version: TAG=7.01g
+;; Version: 7.4
;;
;; This file is part of GNU Emacs.
;;
@@ -46,8 +46,11 @@
(require 'org)
-(declare-function doc-view-goto-page "doc-view" (page))
-(declare-function doc-view-current-page "doc-view" (&optional win))
+(declare-function doc-view-goto-page "ext:doc-view" (page))
+(declare-function image-mode-window-get "ext:image-mode"
+ (prop &optional winprops))
+
+(autoload 'doc-view-goto-page "doc-view")
(org-add-link-type "docview" 'org-docview-open)
(add-hook 'org-store-link-functions 'org-docview-store-link)
@@ -66,7 +69,7 @@
(when (eq major-mode 'doc-view-mode)
;; This buffer is in doc-view-mode
(let* ((path buffer-file-name)
- (page (doc-view-current-page))
+ (page (image-mode-window-get 'page))
(link (concat "docview:" path "::" (number-to-string page)))
(description ""))
(org-store-link-props
Thanks for your time,
Nick
-- System Information:
Debian Release: 6.0
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages org-mode depends on:
ii dpkg 1.15.8.8 Debian package management system
ii emacs23 23.2+1-7 The GNU Emacs editor (with GTK+ us
ii install-info 4.13a.dfsg.1-6 Manage installed documentation in
org-mode recommends no packages.
Versions of packages org-mode suggests:
pn ditaa <none> (no description available)
ii easypg 0.0.16-2.1 yet another GnuPG interface for Em
ii remember-el 1.9-1.1 remember text within Emacs
-- no debconf information
