Package: git-svn
Version: 1:1.7.2.3-2.2
Severity: normal
Tags: patch
When using git svn rebase from a script with the config option
log.decorate=short set, it produces the following errors:
Use of uninitialized value $hash in string eq at /usr/lib/git-core/git-svn line
1532.
These appear to be harmless and using it, either directly on the command line
or without this option set removes the message.
The attached patch fixes the issue, however it is a fairly cheap hack.
I also note that the number of revisions inspected is different when run in a
script vs on the command line. I'm not sure if this is relevant or a bug as it
seems to be harmless.
Thanks,
Julian Calaby
-- System Information:
Debian Release: 6.0
APT prefers testing-proposed-updates
APT policy: (500, 'testing-proposed-updates'), (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages git-svn depends on:
ii git 1:1.7.2.3-2.2 fast, scalable, distributed revisi
ii libsvn-perl 1.6.12dfsg-4 Perl bindings for Subversion
ii libterm-readkey-perl 2.30-4 A perl module for simple terminal
ii libwww-perl 5.836-1 Perl HTTP/WWW client/server librar
git-svn recommends no packages.
Versions of packages git-svn suggests:
ii git-doc 1:1.7.2.3-2.2 fast, scalable, distributed revisi
ii subversion 1.6.12dfsg-4 Advanced version control system
-- no debconf information
--- original/git-svn 2010-12-16 20:35:41.000000000 +1100
+++ rebase-bug/git-svn 2011-01-19 09:12:47.000000000 +1100
@@ -1518,7 +1518,7 @@
my $hash;
my %max;
while (<$fh>) {
- if ( m{^commit ($::sha1)$} ) {
+ if ( m{^commit ($::sha1)(\s|$)} ) {
unshift @$refs, $hash if $hash and $refs;
$hash = $1;
next;
