Package: maint-guide
Version: 1.2.25
Severity: wishlist
Tags: patch
Hi.
I've attached two patches which do hopefully the following:
1) 01_better_wording
- Adapt the order of the commands to the order of VCS tools named before.
2) 02_quiltrc
- Replace the IMO unnecessary [ ... ] && [ ... ] with a (faster?) [ ... -a ...
] .
- At several places, qoute the "d" var, and the output of command substitution,
just in case someone uses weird directories with spaces or so.
btw: Are there other places/packages where the .quiltrc example is used
and where we should update it?
HTH,
Chris.
--- a/maint-guide.en.sgml
+++ b/maint-guide.en.sgml
@@ -515,7 +515,7 @@
<p>If the latest version of such sources are available through VCS such as
Git, Subversion, or CVS repository, you need to get it with "<tt>git
- clone</tt>", "<tt>cvs co</tt>", or "<tt>svn co</tt>" and repack it into
+ clone</tt>", "<tt>svn co</tt>", or "<tt>cvs co</tt>" and repack it into
<prgn>tar</prgn>+<prgn>gzip</prgn> format by yourself using the
"<tt>--exclude-vcs</tt>" option.
--- a/maint-guide.en.sgml
+++ b/maint-guide.en.sgml
@@ -780,15 +780,15 @@
</footnote>
<example>
-d=. ; while [ ! -d "$d/debian" -a `readlink -e $d` != / ]; do d="$d/.."; done
-if [ -d "$d/debian" ] && [ -z "$QUILT_PATCHES" ]; then
+d=. ; while [ ! -d "$d/debian" -a "$( readlink -e "$d" )" != / ]; do
d="$d/.."; done
+if [ -d "$d/debian" -a -z "$QUILT_PATCHES" ]; then
# Debian packaging case and unset $QUILT_PATCHES
QUILT_PATCHES=debian/patches
QUILT_PATCH_OPTS="--unified-reject-files"
QUILT_DIFF_ARGS="-p ab --no-timestamps --no-index --color=auto"
QUILT_REFRESH_ARGS="-p ab --no-timestamps --no-index"
QUILT_COLORS="diff_hdr=1;32:diff_add=1;34:diff_rem=1;31:diff_hunk=1;33:diff_ctx=35:diff_cctx=33"
- if ! [ -d $d/debian/patches ]; then mkdir $d/debian/patches; fi
+ if ! [ -d "$d/debian/patches" ]; then mkdir "$d/debian/patches"; fi
fi
</example>
