severity 608790 serious
tags 608790 patch
thanks
raising the severity, since this breaks a variety of v4l2 cameras.
apparently, it appears that the patch referred to was in reversed order, which
made it look like the patch was already applied. here's a diff with more
context for easier reading:
diff -r e86f1bba22fd src/zm_local_camera.cpp
--- a/src/zm_local_camera.cpp Sat Sep 18 17:31:59 2010 -0700
+++ b/src/zm_local_camera.cpp Thu Jan 06 12:50:53 2011 -0800
@@ -908,7 +908,8 @@
struct v4l2_crop crop;
memset( &crop, 0, sizeof(crop) );
crop.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
- if ( vidioctl( vid_fd, VIDIOC_G_CROP, &crop ) < 0 )
+ int crop_rc = vidioctl( vid_fd, VIDIOC_G_CROP, &crop );
+ if ((crop_rc < 0 ) && (errno != EINVAL))
{
Error( "Failed to query crop: %s", strerror(errno) );
if ( verbose )
@@ -917,8 +918,14 @@
sprintf( output, "error%d\n", errno );
return( false );
}
- if ( verbose )
- sprintf( output+strlen(output), " Current: %d x %d\n",
crop.c.width, crop.c.height );
+ if ( verbose ) {
+ if (crop_rc >= 0) {
+ sprintf( output+strlen(output), " Current: %d x %d\n",
crop.c.width, crop.c.height );
+ }
+ else {
+ sprintf( output+strlen(output), " Current: Cropping is not
supported\n");
+ }
+ }
struct v4l2_input input;
int inputIndex = 0;
i don't have an environment in which i can test this at the moment... can you
test this? or if i built packages for you, could you test it?
live well,
vagrant
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
