I've looked at the provided patch, and I don't think it's correct.
First of all, we have vsscanf in glibc, so there's no reason that we
should need to provide one.  Second, if this code is built as a shared
library, which I believe it is, then we've just exported a symbol by
removing the "static".  That's bad because (a) it conflicts with glibc,
which may cause linking problems and crashes, and (b) other shared
libraries may use this vsscanf, which will not work if there are more
than five stdarg arguments.

The right way to fix this is to find out why HAVE_VSSCANF is not be
defined properly.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187

Attachment: signature.asc
Description: Digital signature

Reply via email to