Hi Rafael,
first of all, let me thank you for working on reportbug bugs!
On Sun, Dec 5, 2010 at 17:32, Rafael Cunha de Almeida
<raf...@kontesti.me> wrote:
> On Wed, Jan 02, 2008 at 05:59:15AM -0800, Josh Triplett wrote:
>> Package: reportbug
>> Version: 3.39
>> Severity: wishlist
>>
>> Using bts from devscripts, "bts show --mbox $BUGNUM" will download the
>> mbox for $BUGNUM and show it in a mailer, defaulting to mutt ("mutt -f
>> %s"). I'd love to have the same feature in querybts and reportbug, so
>> that when viewing a bug, I could press a key (such as 'm', which looks
>> available) to see the mbox.
>
> I wrote a patch that implements that feature. I tried to follow the same
> style of the rest of the code, but if anyone thinks the patch is not
> good enough, just talk to me and I will change it as needed.
These are my impressions, just looking at the patch (so still even trying them):
- I don't like the add of a submodule just to handle the mbox launcher
method: reportbug.utils seems more than enough
- don't add 2 different options between querybts and reportbug: if
reportbug doesn't have '-e' free, just use the long option
- I'm not sure I want this feature also in reportbug: just in querybts?
- you call it everywhere mbox_something, so even use '-e' command-line
option, and also as an option inside reportbug seems wrong: let's try
to recall mbox somehow ('x'?).
- 'e' : 'Launch e-mail client to read full log.' and 'e' : 'Open a
specific report using the specified mbox reader.' - try use the same
message consistently (and the second one doesn't seem in english :) ).
- I don't like that much validation check on bug number in the text_ui
code, better implement it in the code that's going to fetch the data
(so you'll have it once, and not cut&paste twice).
Cheers,
--
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
