On Thu, Dec 09, 2010 at 11:26:18AM -0500, Mark Brown wrote:
> *** /root/grub.d/20_linux_xen/ro2010-12-09 11:04:15.000000000
> -050020_linux_xen
> --- /etc/grub.d/20_linux_xen 2010-12-09 11:04:33.000000000 -0500
> *************** linux_entry ()
> *** 73,80 ****
> printf '%s\n' "${prepare_boot_cache}"
> cat << EOF
> echo '$(printf "$(gettext_quoted "Loading Linux %s ...")"
> ${version})'
> ! multiboot ${rel_xen_dirname}/${xen_basename} placeholder
> ${xen_args}
> ! module ${rel_dirname}/${basename} placeholder
> root=${linux_root_device_thisversion} ro ${args}
> EOF
> if test -n "${initrd}" ; then
> cat << EOF
> --- 73,80 ----
> printf '%s\n' "${prepare_boot_cache}"
> cat << EOF
> echo '$(printf "$(gettext_quoted "Loading Linux %s ...")"
> ${version})'
> ! multiboot ${rel_xen_dirname}/${xen_basename} ${xen_args}
> ! module ${rel_dirname}/${basename}
> root=${linux_root_device_thisversion} ro ${args}
> EOF
> if test -n "${initrd}" ; then
> cat << EOF
No - this will break. The placeholder parameter was deliberately added
because GRUB's Multiboot command-line handling changed. See:
http://lists.gnu.org/archive/html/grub-devel/2010-01/msg00193.html
If we made the change you suggest, then the first entry in ${xen_args}
would be ignored, as well as the root= parameter to 'module'.
Are you having a specific problem here, or were you just reading the
code?
Regards,
--
Colin Watson [[email protected]]
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
