tags 601753 patch
thanks

Hi,

I just installed bouml and tested this:

 - Run bouml;
 - Click OK on the greeting dialog;
 - Close bouml;
 - Repeat.

I get the greeting dialog every time, probably because I'm not loading
any project, and I have to admit it's rather irritating.

I can understand the motivation (although I much prefer when asked for a
donation in the Help->About screen, and would be more inclined to donate
in that case), but forcing the user to wait 5 seconds or so every time
(or even every thirty time) is I think too constraining (reminds me of
unskipable trailers/advertisement on commercial DVDs, that only make
illegal downloading a more attractive alternative).

How about, as a compromise, keeping the greeting dialog but removing the
mandatory waiting period?

Here's a patch that implements just that.

Cheers,

-- 
Benoît Knecht

---

diff --git a/src/dialog/GreetingsDialog.cpp b/src/dialog/GreetingsDialog.cpp
index 09b8039..98f521b 100644
--- a/src/dialog/GreetingsDialog.cpp
+++ b/src/dialog/GreetingsDialog.cpp
@@ -86,7 +86,8 @@ Bruno Pages<i> <i>http://bouml.free.fr</i>\n\
   
   ok = new QPushButton("&OK", this);
   ok->setDefault(TRUE);
-  ok->setEnabled(FALSE);
+  ok->setEnabled(TRUE);
+  ok->setFocus();
   
   hbox->addWidget(new QLabel(this));
   hbox->addWidget(ok);
@@ -96,14 +97,6 @@ Bruno Pages<i> <i>http://bouml.free.fr</i>\n\
     UmlDesktop::tocenter(this);
   
   connect(ok, SIGNAL(clicked()), this, SLOT(reject()));
-  
-  QTimer::singleShot(5000, this, SLOT(valid_ok()));
-  QApplication::setOverrideCursor(Qt::waitCursor);
-}
-
-void GreetingsDialog::valid_ok() {
-  ok->setEnabled(TRUE);
-  QApplication::restoreOverrideCursor();
 }
 
 void GreetingsDialog::closeEvent(QCloseEvent * e) {
diff --git a/src/dialog/GreetingsDialog.h b/src/dialog/GreetingsDialog.h
index b6edd2f..43ce9be 100644
--- a/src/dialog/GreetingsDialog.h
+++ b/src/dialog/GreetingsDialog.h
@@ -41,7 +41,6 @@ class GreetingsDialog : public QDialog {
   
   protected slots:
     virtual void closeEvent(QCloseEvent * e);
-    void valid_ok();
 };
 
 #endif



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to