Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Thanks for your efforts towards great Debian releases! I've made some changes towards a new version of my wmanager package, mainly to close #605043 that the submitter kindly placed at "normal" severity, although I think that for everyone using wmanagerrc-update in non-English locales with translated update-alternatives messages it pretty much makes this little part of wmanager quite unusable. (I never noticed it since update-alternatives does not have Bulgarian message translations) Would this be considered a good enough reason to unblock wmanager-0.2.1-9 for Squeeze? I've not uploaded it yet, and I've also taken the liberty of making some other changes that should be no-ops from a usability and buildability (to coin a word) standpoint; you may find them in the attached debdiff: - a Standards-Version 3.9.0 -> 3.9.1 bump with no changes - a debhelper compat level 7 -> 8 bump with no changes - add bzip2 compression to debian/source/options - change the Vcs-* fields to point to my new Gitorious repository - depend on the hardening-wrapper package: this might look scary, but it is actually a no-op unless the non-standard "hardening" option is defined in DEB_BUILD_OPTIONS at build time. None of the autobuilders does that, at least AFAIK :) - fix the update-alternatives usage bug from #605043 - the real reason Of course, should you say those are too much for a testing migration at this point, it'll be fine, it can wait until after Squeeze. Should you say I should make it so only the #605043 fix is included, I could do that :) Should you accept these changes, I will upload the package and let you know afterwards so it may be unblocked. Thanks for your time and all your work on Debian! unblock wmanager/0.2.1-9 -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (990, 'testing'), (500, 'oldstable'), (500, 'stable') Architecture: i386 (i686) Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores) Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash
diffstat for wmanager-0.2.1 wmanager-0.2.1 changelog | 13 +++++++++++++ compat | 2 +- control | 9 +++++---- source/options | 2 ++ wmanagerrc-update | 8 ++++---- 5 files changed, 25 insertions(+), 9 deletions(-) diff -Nru wmanager-0.2.1/debian/changelog wmanager-0.2.1/debian/changelog --- wmanager-0.2.1/debian/changelog 2010-06-29 00:29:46.000000000 +0300 +++ wmanager-0.2.1/debian/changelog 2010-11-28 13:51:58.000000000 +0200 @@ -1,3 +1,16 @@ +wmanager (0.2.1-9) unstable; urgency=low + + * Bump Standards-Version to 3.9.1 with no changes. + * Let wmanagerrc-update use update-alternatives --query, not --display, + to fix its operation with non-English text. Closes: #605043 + * Actually depend on the hardening-wrapper so if "hardening" will indeed + have some effect if specified in DEB_BUILD_OPTIONS. + * Switch to Git and point the Vcs-* fields to Gitorious. + * Use bzip2 compression for the Debian tarball. + * Bump the debhelper compatibility level to 8 with no changes. + + -- Peter Pentchev <r...@ringlet.net> Sun, 28 Nov 2010 13:46:44 +0200 + wmanager (0.2.1-8) unstable; urgency=low * Bump Standards-Version to 3.9.0 with no changes. diff -Nru wmanager-0.2.1/debian/compat wmanager-0.2.1/debian/compat --- wmanager-0.2.1/debian/compat 2008-07-02 15:10:59.000000000 +0300 +++ wmanager-0.2.1/debian/compat 2010-11-28 13:51:47.000000000 +0200 @@ -1 +1 @@ -7 +8 diff -Nru wmanager-0.2.1/debian/control wmanager-0.2.1/debian/control --- wmanager-0.2.1/debian/control 2010-06-29 10:07:28.000000000 +0300 +++ wmanager-0.2.1/debian/control 2010-11-28 13:52:03.000000000 +0200 @@ -3,11 +3,12 @@ Priority: optional Maintainer: Peter Pentchev <r...@ringlet.net> DM-Upload-Allowed: yes -Standards-Version: 3.9.0 -Build-Depends: debhelper (>= 7.0.50), dpkg-dev (>= 1.15.7~), libfltk1.1-dev +Standards-Version: 3.9.1 +Build-Depends: debhelper (>= 8), dpkg-dev (>= 1.15.7~), hardening-wrapper, + libfltk1.1-dev Homepage: http://www.daemogorgon.net/software/wmanager/ -Vcs-Svn: http://svn.ringlet.net/svn/ringlet/x11/wmanager/trunk/wmanager-pkg/debian/ -Vcs-Browser: http://svn.ringlet.net/v/ringlet/x11/wmanager/trunk/wmanager-pkg/debian/ +Vcs-Git: git://gitorious.org/wmanager/wmanager-pkg-debian/ +Vcs-Browser: http://gitorious.org/wmanager/wmanager-pkg-debian/ Package: wmanager Architecture: any diff -Nru wmanager-0.2.1/debian/source/options wmanager-0.2.1/debian/source/options --- wmanager-0.2.1/debian/source/options 1970-01-01 02:00:00.000000000 +0200 +++ wmanager-0.2.1/debian/source/options 2010-11-28 13:44:44.000000000 +0200 @@ -0,0 +1,2 @@ +compression = "bzip2" +compression-level = 9 diff -Nru wmanager-0.2.1/debian/wmanagerrc-update wmanager-0.2.1/debian/wmanagerrc-update --- wmanager-0.2.1/debian/wmanagerrc-update 2008-07-02 18:22:02.000000000 +0300 +++ wmanager-0.2.1/debian/wmanagerrc-update 2010-11-28 13:44:16.000000000 +0200 @@ -2,7 +2,7 @@ # wmanagerrc-update -- update your wmanager settings automatically # Copyright (C) 2000 Tommi Virtanen <t...@debian.org> -# Copyright (C) 2008 Peter Pentchev <r...@ringlet.net> +# Copyright (C) 2008, 2010 Peter Pentchev <r...@ringlet.net> # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -21,10 +21,10 @@ { cat "$HOME/.wmanagerrc.user" 2>/dev/null || true [ ! -x /usr/sbin/update-alternatives ] || - /usr/sbin/update-alternatives --display x-window-manager \ + /usr/sbin/update-alternatives --query x-window-manager \ |perl -ne ' - m{^(/.*) - priority (\d+)$} or next; - push @{$p{$2}}, $1; + m{^Alternative:\s+([/\w]+)$} and $alt = $1; + m{^Priority:\s+(\d+)$} and push @{$p{$1}}, $alt; END { print map {"$_\000"}
signature.asc
Description: Digital signature
