Hi again,
Kevin Ryde wrote:
> Jonathan Nieder <[email protected]> writes:
>> In git-blame-cleanup:
>> git-blame.el:306:6:Warning: `mapcar' called for effect; use `mapc' or
>> `dolist'
>> instead
>
> True but not very important.
>
>> In git-blame-filter:
>> git-blame.el:338:31:Warning: `save-excursion' defeated by `set-buffer'
>> In git-blame-create-overlay:
>> git-blame.el:386:50:Warning: `save-excursion' defeated by `set-buffer'
>
> Maybe should be `with-current-buffer' per the elisp manual example.
> I hadn't noticed any obvious ill effect, but I don't think I tried it
> much.
>
>> git-blame.el:389:12:Warning: `goto-line' used from Lisp code
>> That command is designed for interactive use only
>
> True but not fatal. I see the `goto-line' docstring recommends
> `forward-line'.
Thanks for the analysis. In order to
1) suppress these warnings when the elisp is compiled,
and
2) make sure git's emacs support is not broken by a random
future emacs upgrade
I think it is worth fixing these. Any pointers? How can one retrieve
elisp docstrings, and is there a postscript or HTML reference manual?
Thanks again for all the help. I don't know what I'd do without it.
Jonathan
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
