On Mon, Oct 25, 2010 at 12:35:38PM +0200, Alan DeKok wrote: > Josip Rodin wrote: > > [For Alan: I requested for FreeRADIUS 2.1.10 to replace 2.1.9 in the future > > Debian 6.0 release; the former came too late in our process to be accepted > > automatically.] > > OK. > > >> This, from main/events.c, looks obviously wrong, however: > >> > >> + home->zombie_period_start.tv_sec = home->last_packet; > >> + home->zombie_period_start.tv_sec = USEC / 2; > >> > >> Presumably the second tv_sec should be tv_usec. > > Yes, ouch. > > > Yeah, that sounds like it to me, too. That change came in this commit > > http://github.com/alandekok/freeradius-server/commit/f8bcc0fe > > which actually probably fixed a fatal crash (the assert call removed > > because "Don't check home->ev due to race conditions."), so that's still > > probably better than one randomized zombie period start (which can > > get reset and/or ignored soon enough anyway) which is why nobody else > > noticed. > > > > Alan, is this correct? > > Yes. I'll commit a fix.
Josip, Alan's fix has been commited: http://github.com/alandekok/freeradius-server/commit/7b7dff7724721f8af5fd163f2292d427a869992d Could you upload a fixed version? Cheers, Moritz -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
