Package: flog
Version: 1.8-2
Around line 105 we have:
if (conf.pidfile) {
pid_fd = fopen(conf.pidfile_name, "w");
if ((pid_fd = fopen(conf.pidfile_name, "w")) == NULL) {
fprintf (stderr, "Could not open pidile: %s",
conf.pidfile_name);
exit(1);
}else if (pid_fd) {
fprintf(pid_fd, "%lu\n", (unsigned long)getpid());
fclose(pid_fd);
}
}
We see that the pid filename is opened twice; the first one should be
removed.
Also, the conf.pid member is unnecessary, since the fprintf above
calls getipid() directly. So this field can be removed from the struct
declaration and also the assignment around line 80.
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
