Hi Daniel

I think I will wait for upstream to propose their change for this.
The reason is that I would like to see the upstream solution for
the getpwuid(0)->pw_dir part. I fully agree that we should not
set HOME to /root.

Just for my own couriousity, why would you run bazarr with
vzctl exec?

Best regards,

// Ola

On Mon, Sep 20, 2010 at 08:59:01PM +0200, Daniel Hahler wrote:
> Package: vzctl
> Version: 3.0.24-3
> Severity: normal
> Tags: patch upstream
> 
> "vzctl enter" and "vzctl exec" do some odd things to the process
> environment:
>  - HOME gets set to "/" (except for "enter")
>  - HISTFILE gets set to /dev/null (for "enter")
> 
> I have reported this upstream [1], and got the feedback that my proposed
> patch should use getpwuid(0)->pw_dir instead of forcing "/root" [2].
> 
> You might want to improve my patch in this direction (after fixing
> anything else I might have broken - especially regarding the HISTFILE
> handling I am not sure if this is correct).
> 
> The main reason for this patch is to get the home directory right, which
> otherwise might confuse programs like Bazaar [3].
> 
> Not using HISTFILE=/dev/null is useful to get the history of your
> commands stored after all.
> 
> The Launchpad bug tracking this is also at [3].
> 
> 
> 1: http://bugzilla.openvz.org/show_bug.cgi?id=942
> 2: http://bugzilla.openvz.org/show_bug.cgi?id=942#c1
> 3: https://bugs.launchpad.net/bzr/+bug/622898
> 
> 
> -- System Information:
> Debian Release: squeeze/sid
>   APT prefers maverick
>   APT policy: (500, 'maverick')
> Architecture: i386 (i686)
> 
> Kernel: Linux 2.6.35-22-generic (SMP w/2 CPU cores)
> Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash



-- 
 --------------------- Ola Lundqvist ---------------------------
/  [email protected]                     Annebergsslingan 37      \
|  [email protected]                      654 65 KARLSTAD          |
|  http://inguza.com/                  +46 (0)70-332 1551       |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36  4FE4 18A1 B1CF 0FE5 3DD9 /
 ---------------------------------------------------------------



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to