Package: general Severity: serious Tags: patch Justification: fails to build from source (but built successfully in the past)
soleil:/usr/src# uname -a Linux soleil 2.6.32-3-ieee1394 #1 SMP Mon Jun 7 13:44:44 CEST 2010 i686 GNU/Linux I run DEBIAN squeeze updated this week. Steps to reproduce: after loading all dependency according to the debian source pkg "vlc_1.1.2.orig.tar.bz2" . 1) Extrac the VLC source in /usr/src (i get a directory named vlc-1.1.2) 2)configure : # ./configure --enable-run-as-root : résult ok. 3)Compile using make or ./compile : result ok 4) Launch vlc from the current directory as well:#./vlc result OK (work find) 5) Try to make the .deb file as describe in "building package" "DEBIAN" To build a Debian package, you need to get the packaging info svn co svn://svn.debian.org/pkg-multimedia/videolan/vlc/debian debian (ok) and then dpkg-buildpackage -rfakeroot -us -uc (fail) the results are : dpkg-source: info: utilisation du format source « 1.0 » dpkg-source: info: construction de vlc dans vlc_1.0.0-git-1.tar.gz dpkg-source: info: construction de vlc dans vlc_1.0.0-git-1.dsc QUILT_PATCHES=debian/patches \ quilt --quiltrc /dev/null push -a || test $? = 2 Application de 052_as-needed.diff patching file autotools/ltmain.sh Hunk #1 succeeded at 4716 with fuzz 2 (offset 2909 lines). Hunk #2 succeeded at 5075 (offset 2920 lines). Application de 101_certificates_paths.diff patching file modules/misc/gnutls.c Hunk #1 succeeded at 699 (offset 11 lines). Application de 102_dejavu_font.diff patching file modules/misc/freetype.c Hunk #1 succeeded at 67 with fuzz 2 (offset 6 lines). Application de 104_notify.diff patching file modules/misc/notify/notify.c Hunk #1 FAILED at 216. 1 out of 1 hunk FAILED -- rejects in file modules/misc/notify/notify.c Le patch 104_notify.diff ne s'applique pas proprement (forcez l'application avec -f) It seem to be a bug in the patch file 104_notify.diff, and I am unable to solve it. Note that the LOCALE LANG=fr_FR.UTF-8 is not apply, vlc remain in english. Could you please note this problem ? Same problem with vlc_1.1.3.ori.tar.bz2 Best regards Hoareau Jean Pierre -- System Information: Debian Release: squeeze/sid APT prefers testing-proposed-updates APT policy: (500, 'testing-proposed-updates'), (500, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.32-3-ieee1394 (SMP w/4 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
Index: vlc-0.9.1/modules/misc/notify/notify.c =================================================================== --- vlc-0.9.1.orig/modules/misc/notify/notify.c 2008-08-25 23:40:43.000000000 +0200 +++ vlc-0.9.1/modules/misc/notify/notify.c 2008-09-04 00:46:24.000000000 +0200 @@ -216,13 +216,7 @@ free( psz_arturl ); } else /* else we show state-of-the art logo */ - { - const char *data_path = config_GetDataDir (); - char buf[strlen (data_path) + sizeof ("/vlc48x48.png")]; - - snprintf (buf, sizeof (buf), "%s/vlc48x48.png", data_path); - pix = gdk_pixbuf_new_from_file( buf, &p_error ); - } + pix = gdk_pixbuf_new_from_file( "/usr/share/pixmaps/vlc.png", &p_error ); /* we need to replace '&' with '&' because '&' is a keyword of * notification-daemon parser */