Bug#323522: FTBFS: Labels at the end of compound statements

[Matt Kraai]

Package: lids-2.4
Version: 1.1.1r2-5
Severity: serious
Tags: patch

lids-2.4 fails to build because it contains labels at the end of
compound statements:

> source='lidsadm.c' object='lidsadm.o' libtool=no \
> depfile='.deps/lidsadm.Po' tmpdepfile='.deps/lidsadm.TPo' \
> depmode=gcc3 /bin/sh ../depcomp \
> gcc -DHAVE_CONFIG_H -I. -I. -I..     -I. -DCONFIG_LIDS -c `test -f lidsadm.c 
> || echo './'`lidsadm.c
> lidsadm.c: In function 'exit_error':
> lidsadm.c:60: warning: incompatible implicit declaration of built-in function 
> 'exit'
> lidsadm.c: In function 'exit_version':
> lidsadm.c:66: warning: incompatible implicit declaration of built-in function 
> 'exit'
> lidsadm.c: In function 'exit_normal':
> lidsadm.c:73: warning: incompatible implicit declaration of built-in function 
> 'exit'
> lidsadm.c: In function 'exit_help':
> lidsadm.c:107: warning: incompatible implicit declaration of built-in 
> function 'exit'
> lidsadm.c: In function 'lids_set_caps':
> lidsadm.c:130: warning: incompatible implicit declaration of built-in 
> function 'exit'
> lidsadm.c:151: warning: incompatible implicit declaration of built-in 
> function 'exit'
> lidsadm.c: In function 'lids_switch':
> lidsadm.c:184: warning: incompatible implicit declaration of built-in 
> function 'strncpy'
> lidsadm.c: In function 'main':
> lidsadm.c:366: error: label at end of compound statement
> lidsadm.c:390: warning: incompatible implicit declaration of built-in 
> function 'exit'

These labels occur after the default label at the end of switch
statements.  The attached patch adds break statements, which fixes the
problem without changing the behavior.

-- 
Matt

diff -u lids-2.4-1.1.1r2/lidstools/lidsconf.c 
lids-2.4-1.1.1r2/lidstools/lidsconf.c
--- lids-2.4-1.1.1r2/lidstools/lidsconf.c
+++ lids-2.4-1.1.1r2/lidstools/lidsconf.c
@@ -804,6 +804,7 @@
                        case 'h':
                                exit_help();
                        default:
+                               break;
                        }
        }
        
only in patch2:
unchanged:
--- lids-2.4-1.1.1r2.orig/lidstools/lidsadm.c
+++ lids-2.4-1.1.1r2/lidstools/lidsadm.c
@@ -363,6 +363,7 @@
                        case 'h':
                                exit_help();
                        default:
+                               break;
                        }
        }
        

signature.asc
Description: Digital signature