tags 589211 + patch clone 589211 -1 retitle -1 gtk-redshift: doesn't depend on python severity -1 serious thanks
* Marco Túlio Gontijo e Silva <mar...@debian.org>, 2010-07-15, 16:48:
If I click the Status Icon and Toggle, it gives me in the terminal that I ran gtk-redshift: Traceback (most recent call last): File "/usr/lib/pymodules/python2.5/gtk_redshift/statusicon.py", line 51, in toggle_cb process.send_signal(signal.SIGUSR1) AttributeError: 'Popen' object has no attribute 'send_signal' If I click Quit (or if I press C-c in the term): Traceback (most recent call last): File "/usr/bin/gtk-redshift", line 23, in <module> run_statusicon() File "/usr/lib/pymodules/python2.5/gtk_redshift/statusicon.py", line 94, in run_statusicon process.terminate() AttributeError: 'Popen' object has no attribute 'terminate'
Popen objects have send_singal() and terminate() methods in Python 2.6, but not in earlier versions. However, gtk-redshift doesn't have proper versioned dependency on python. Well, in fact, it doesn't depend on python at all.
The attached patch should fix both bugs. -- Jakub Wilk
diff -Nru redshift-1.2/debian/control redshift-1.2/debian/control --- redshift-1.2/debian/control 2010-02-21 15:35:30.000000000 +0100 +++ redshift-1.2/debian/control 2010-07-18 08:35:24.000000000 +0200 @@ -2,7 +2,8 @@ Section: x11 Priority: extra Maintainer: Simon Richter <s...@debian.org> -Build-Depends: debhelper (>= 7), autotools-dev, pkg-config, libx11-dev, libxcb-randr0-dev, libxxf86vm-dev, python-dev +Build-Depends: debhelper (>= 7), autotools-dev, pkg-config, libx11-dev, libxcb-randr0-dev, libxxf86vm-dev, python, python-support +XS-Python-Version: >= 2.6 Standards-Version: 3.8.4 Homepage: https://launchpad.net/redshift @@ -20,7 +21,7 @@ Package: gtk-redshift Architecture: all -Depends: redshift, ${misc:Depends} +Depends: redshift, ${misc:Depends}, ${python:Depends} Description: Adjusts the color temperature of your screen The color temperature is set according to the position of the sun. A different color temperature is set during night and daytime. During
signature.asc
Description: Digital signature
