On Sun, Jul 11, 2010 at 04:07:01PM -0400, Mike Paul wrote:
>tag 588737 patch
>thanks
>
>I traced the problem to a strcpy() call in genisoimage whose arguments
>are overlapping in memory, which isn't allowed but apparently worked
>anyway with the strcpy() implementation in older versions of glibc.  The
>overlap is intentional, so memmove() should be used instead of strcpy().
>
>A patch is attached.

>--- genisoimage/genisoimage.c.orig     2009-08-11 09:27:55.000000000 -0400
>+++ genisoimage/genisoimage.c  2010-07-11 15:36:33.473836763 -0400
>@@ -3166,7 +3166,7 @@
>                               while (*xpnt == PATH_SEPARATOR) {
>                                       xpnt++;
>                               }
>-                              strcpy(graft_point, xpnt);
>+                              memmove(graft_point, xpnt, strlen(xpnt)+1);
>                       } while (xpnt > graft_point);
> 
>                       if (node) {

Excellent work, thanks for this. Committing to svn now.

-- 
Steve McIntyre, Cambridge, UK.                                st...@einval.com
"You can't barbecue lettuce!" -- Ellie Crane




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to