On 2010-06-20 15:42, Cyril Brulebois wrote:
> Source: sentinella
> Version: 0.6.1-1
> Severity: serious
> Justification: FTBFS
> User: [email protected]
> Usertags: kfreebsd
> 
> Hi,
> 

Hi

> your package no longer builds on kfreebsd-*:

Sentinella never built on kFreeBSD (Sentinella has only been uploaded
once :P).
  It is already fixed in the next version (I submitted a RFS yesterday)
and hope to hear from my sponsor soon.

> | [ 58%] Building CXX object src/CMakeFiles/sentinella.dir/MainWindow.o
> | cd 
> /build/buildd-sentinella_0.6.1-1-kfreebsd-amd64-G9y4TU/sentinella-0.6.1/obj-x86_64-kfreebsd-gnu/src
>  && /usr/bin/c++    -g -O2 -Woverloaded-virtual -fno-threadsafe-statics 
> -fvisibility=hidden -fvisibility-inlines-hidden -O2 -g -DNDEBUG -DQT_NO_DEBUG 
> -I/build/buildd-sentinella_0.6.1-1-kfreebsd-amd64-G9y4TU/sentinella-0.6.1/obj-x86_64-kfreebsd-gnu/src
>  
> -I/build/buildd-sentinella_0.6.1-1-kfreebsd-amd64-G9y4TU/sentinella-0.6.1/src 
> -I/usr/include/KDE -I/usr/include/qt4/phonon -I/usr/include/qt4/QtXmlPatterns 
> -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtWebKit 
> -I/usr/include/qt4/QtUiTools -I/usr/include/qt4/QtTest 
> -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtSql 
> -I/usr/include/qt4/QtScriptTools -I/usr/include/qt4/QtScript 
> -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtMultimedia 
> -I/usr/include/qt4/QtHelp -I/usr/include/qt4/QtDesigner 
> -I/usr/include/qt4/QtDBus -I/usr/include/qt4/QtAssistant 
> -I/usr/include/qt4/Qt3Support -I/usr/include/qt4/QtGui 
> -I/usr/include/qt4/QtCore -I
/usr/include/qt4/Qt -I/usr/share/qt4/mkspecs/default -I/usr/include/qt4   -o 
CMakeFiles/sentinella.dir/MainWindow.o -c 
/build/buildd-sentinella_0.6.1-1-kfreebsd-amd64-G9y4TU/sentinella-0.6.1/src/MainWindow.cpp
> | 
> /build/buildd-sentinella_0.6.1-1-kfreebsd-amd64-G9y4TU/sentinella-0.6.1/src/MainWindow.cpp:
>  In member function 'void MainWindow::initConditionWidgets(short int)':
> | 
> /build/buildd-sentinella_0.6.1-1-kfreebsd-amd64-G9y4TU/sentinella-0.6.1/src/MainWindow.cpp:168:
>  error: 'sa_close_cpu' was not declared in this scope
> | 
> /build/buildd-sentinella_0.6.1-1-kfreebsd-amd64-G9y4TU/sentinella-0.6.1/src/MainWindow.cpp:
>  In member function 'void MainWindow::initActionWidgets(short int)':
> | 
> /build/buildd-sentinella_0.6.1-1-kfreebsd-amd64-G9y4TU/sentinella-0.6.1/src/MainWindow.cpp:254:
>  error: 'sa_close_cpu' was not declared in this scope
> | make[3]: *** [src/CMakeFiles/sentinella.dir/MainWindow.o] Error 1
> 
> It sounds like it could be a bug in libsysactivity-dev.
> 

My first thought as well, however, the issue is in Sentinella.

> /usr/include/libsysactivity/cpu.h has:
> | #ifdef SA_CLOSE_CPU
> | […]
> | SA_EXPORT int sa_close_cpu(void);
> | #endif
> 
> ./src/Conditions/CPU.cpp has:
> | #ifdef SA_CLOSE_CPU
> |         sa_close_cpu();
> | #endif
> 

Yes, however the faulty file has (something like):

| #ifdef SA_CLOSE_PROCESS
|         sa_close_cpu();
| #endif

So the issue is actually a poorly written #ifdef. This also have a
wonderful side effect of causing leaks on all architectures that do not
FTBFS.

> So it sounds quite sane.
> 
> Meanwhile:
> | $ nm -D /usr/lib/libsysactivity.so|grep sa_close
> | 00002260 T sa_close_process
> 
> I'm anyway opening a bug here first since your package FTBFS and that's
> a regression. Feel free to point me to anything I could have missed, or
> to open a bug against libsysactivity since it looks like it's missing
> some symbols.
> 
> Full build logs:
>   https://buildd.debian.org/status/package.php?p=sentinella
> 
> Mraw,
> KiBi.
> 

Thanks for reporting, :)
~Niels

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to