On Fri, May 07, 2010 at 09:05:55PM -0700, tony mancill wrote:
> +  * debian/rules
> +    - (build-stamp): Check that DISPLAY is set before running tests.
> [...]
> -     $(MAKE) check
> +     [ ! "$DISPLAY" ] || $(MAKE) check
I don't understand the need for this change.  What error were you getting that
motivated this change?

The only test script which seems to run anything which might use X is
tests/smoketest.tst, and in there testing of aven is already protected by:

if test -n "$DISPLAY" && test -r "$testdir"/../src/aven ; then

The only other tested binary which uses X is xcaverot, and it looks to me like
xcaverot processes --help and --version before calling XOpenDisplay, so I'm not
seeing why that would need an X display here.  If it really does, the attached
patch would be a much better fix than disabling the whole testsuite.

Cheers,
    Olly
--- survex-1.0.39/tests/smoke.tst.orig	2006-01-09 15:34:50.000000000 +0000
+++ survex-1.0.39/tests/smoke.tst	2010-05-13 01:18:42.692987453 +0100
@@ -30,7 +30,7 @@
 
 PROGS="cad3d cavern printdm printps printpcl printhpgl diffpos extend sorterr\
  3dtopos"
-if test -r "$testdir"/../src/xcaverot ; then
+if test -n "$DISPLAY" && test -r "$testdir"/../src/xcaverot ; then
    PROGS="$PROGS xcaverot"
 fi
 # aven tries to open an X display even for --help and --version

Reply via email to