Hi, On Wed, May 05, 2010 at 09:30:47PM +0400, Ivan Borzenkov wrote: > 5 мая 2010 20:40:05 вы писали: > Hi, > > > > I thought about this a bit more. > > > > I mean this only for the Debian packaging. Since this is tutorial, I do > > not expect people to do unreasonable tool usage. I do not see why we > > need to "test -z $QUILT_PATCHES". If we have debian directory in > > source tree as a debian packager, we expect quilt to be used for debian > > packaging. If we are using quilt as upstream, you never create such > > directory. > > > > But you caused me to rethink a bit. I will move QUILT_* into if...fi to > > ensure this only applies to debian packaging and make this clear by > > comment. > > I think not very well change variable at a time when nothing more can be done > - just before the launch. > > I stumbled upon this when he began collecting psi-plus - is a group of > patches > to psi, now they have not yet come to the conclusion that they need to use > the > quilt, but most likely there are other similar projects. I tried to use when > assembling quilt and got here this unexpected result.
I see ... you must be talking http://code.google.com/p/psi-dev/ > The question is, what to do if the program is in the process of assembly uses > the quilt? Anyway, quilt is bash script. I thought about using syntax like what quilt does to set parameters without overriding it. : ${QUILT_PATCHES:=debian/patches} But is this good? .... may be not > That is why I believe that it is necessary to leave the ability to set the > directory, but there may be quite trivial errors when building packages, > which > themselves use the quilt. OK. I will do this. d=. ; while [ ! -d "$d/debian" -a `readlink -e $d` != / ]; do d="$d/.."; done if [ -d "$d/debian" ] && [ -z "$QUILT_PATCHES" ]; then # Debian packaging case QUILT_PATCHES=debian/patches QUILT_PATCH_OPTS="--unified-reject-files" QUILT_DIFF_ARGS="-p ab --no-timestamps --no-index --color=auto" QUILT_REFRESH_ARGS="-p ab --no-timestamps --no-index" QUILT_COLORS="diff_hdr=1;32:diff_add=1;34:diff_rem=1;31:diff_hunk=1;33:diff_ctx=35:diff_cctx=33" if ! [ -d $d/debian/patches ]; then mkdir $d/debian/patches; fi fi By the way, if you are really needing quilt without with out ~/.quiltrc, you can do this. For this, alias is good to use here like: $ alias quilt0="quilt --quiltrc /dev/null" Then you can use quilt0 for what you need. One thing I worry to do this is .pc directory data crash. As I see your package, this is too complicated for me to critique but I see no reason to have cdbs dependency while you are not using it in psi-plus. But where are these quilt patches used in your package. > Or want to draw attention to this fact in the manual, so that others do not > lose time because of similar problems. I will try this as footnote. Osamu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
