2010/4/16 Jari Aalto <[email protected]>: > Julian Andres Klode <[email protected]> writes: > >>> r1687 nosmart+http://bzr.debian.org/apt/apt/debian-experimental/ >> >> This branch has not been touched since March 2009. You should use >> the debian-sid branch instead. > > Attached. > > against 2010-03-26 r1964 http://bzr.debian.org/apt/debian-sid
Thanks for the update. I like the idea to use long options. :) Still your patch includes some strangers: 1.) Why do you convert commented-out lines intend from tabs to spaces? 2.) change at line 123 regarding Makefile isn't a valid replacement. You replace a check for the Makefile before running the targets to checking for Makefile - OR if it doesn't exist run make targets… 3.) line 225: APT doesn't ship all his manpages in the same package, so your removal of the parameter for dh_installman is wrong. 4.) The two last lines are separated with a newline from the rest of the target - that is wrong. Also, they are separated commands, so adding \ feels strange and conflicts with your own style. I have not looked at each line, so it maybe includes also better hidden buggers ~ could you redo your patch? Best regards / Mit freundlichen Grüßen, David Kalnischkies -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
