Package: predict
Version: 2.2.3-2
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu lucid ubuntu-patch
*** /tmp/tmpqfAjuL
In Ubuntu, the attached patche is proposed for this package to achieve the
following:
* debian/patches/141_buffer_overflow.diff: Fix a buffer overflow that
makes predict-g1yyh crash when printing predictions (p, v, s, n and
o commands). Patch courtesy of Norvald H. Ryeng
I thought you might be interested in apply it in the debian package..
-- System Information:
Debian Release: squeeze/sid
APT prefers lucid-updates
APT policy: (500, 'lucid-updates'), (500, 'lucid-security'), (500,
'lucid-backports'), (500, 'lucid')
Architecture: i386 (i686)
Kernel: Linux 2.6.32-19-generic (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
=== added file 'debian/patches/141_buffer_overflow.diff'
--- debian/patches/141_buffer_overflow.diff 1970-01-01 00:00:00 +0000
+++ debian/patches/141_buffer_overflow.diff 2010-04-03 18:21:56 +0000
@@ -0,0 +1,28 @@
+## Description: Extends header line 2 (head2) with an extra byte for the
terminating \0 and shortens two strings that were 1 byte too long.
+## Origin/Author: Norvald H. Ryeng
+## Bug: https://bugs.launchpad.net/ubuntu/+source/predict/+bug/553140
+Index: predict-2.2.3/predict-g1yyh.c
+===================================================================
+--- predict-2.2.3.orig/predict-g1yyh.c 2010-04-01 11:03:53.472663321 +0200
++++ predict-2.2.3/predict-g1yyh.c 2010-04-01 11:11:19.876662739 +0200
+@@ -4018,7 +4018,7 @@
+ /* This function buffers and displays orbital predictions
+ and allows screens to be saved to a disk file. */
+
+- char type[20], spaces[80], head1[80], head2[80];
++ char type[20], spaces[80], head1[80], head2[81];
+ int key, ans=0, l, x, t;
+ static char buffer[5000], lines, quit;
+ static FILE *fd;
+@@ -4068,9 +4068,9 @@
+ sprintf(head2," Date Mins/Day
Sun Date Mins/Day Sun ");
+ else {
+ if (calc_squint)
+- sprintf(head2," Date Time
El Az Phase %s %s Range Squint
",(io_lat=='N'?"LatN":"LatS"),(io_lon=='W'?"LonW":"LonE"));
++ sprintf(head2," Date Time
El Az Phase %s %s Range Squint
",(io_lat=='N'?"LatN":"LatS"),(io_lon=='W'?"LonW":"LonE"));
+ else
+- sprintf(head2," Date Time
El Az Phase %s %s Range Orbit
",(io_lat=='N'?"LatN":"LatS"),(io_lon=='W'?"LonW":"LonE"));
++ sprintf(head2," Date Time
El Az Phase %s %s Range Orbit
",(io_lat=='N'?"LatN":"LatS"),(io_lon=='W'?"LonW":"LonE"));
+ }
+ }
+
=== modified file 'debian/patches/series'
--- debian/patches/series 2010-03-31 10:18:23 +0000
+++ debian/patches/series 2010-04-03 18:21:56 +0000
@@ -14,3 +14,4 @@
121_predict-g1yyh.diff
130_gtk2.diff
140_fix-buffer-overflow.diff
+141_buffer_overflow.diff
