Bug#573069: dbconfig-common: removal of postgres database and user not working

[J.M.Roth]

Package: dbconfig-common
Version: 1.8.45
Severity: important
Tags: patch

dbconfig-common, when in pgsql mode, does not correctly drop databases and users
because it uses command line parameter -q to dropdb and dropuser, respectively,
which does not exist. in fact, such an action always results in failure.

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-2-686 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages dbconfig-common depends on:
ii  debconf [debconf-2.0]         1.5.28     Debian configuration management sy
ii  ucf                           3.0025     Update Configuration File: preserv

dbconfig-common recommends no packages.

Versions of packages dbconfig-common suggests:
ii  mysql-client-5.1 [virtual-mys 5.1.41-3   MySQL database client binaries
ii  postgresql-client-8.4 [postgr 8.4.2-2+b1 front-end programs for PostgreSQL

-- debconf information:
  dbconfig-common/password-confirm: (password omitted)
  dbconfig-common/mysql/admin-pass: (password omitted)
  dbconfig-common/mysql/app-pass: (password omitted)
  dbconfig-common/pgsql/admin-pass: (password omitted)
  dbconfig-common/pgsql/app-pass: (password omitted)
  dbconfig-common/app-password-confirm: (password omitted)
  dbconfig-common/internal/reconfiguring: false
  dbconfig-common/dbconfig-upgrade: true
  dbconfig-common/remote-questions-default: false
  dbconfig-common/passwords-do-not-match:
  dbconfig-common/pgsql/authmethod-admin: ident
  dbconfig-common/db/basepath:
  dbconfig-common/pgsql/revertconf: false
  dbconfig-common/install-error: abort
  dbconfig-common/remove-error: abort
  dbconfig-common/internal/skip-preseed: false
  dbconfig-common/db/dbname:
  dbconfig-common/pgsql/no-empty-passwords:
  dbconfig-common/mysql/method: unix socket
  dbconfig-common/remember-admin-pass: false
  dbconfig-common/pgsql/admin-user: postgres
  dbconfig-common/mysql/admin-user: root
  dbconfig-common/dbconfig-reinstall: false
  dbconfig-common/remote/host:
  dbconfig-common/pgsql/manualconf:
  dbconfig-common/pgsql/changeconf: false
  dbconfig-common/remote/newhost:
  dbconfig-common/dbconfig-install: true
  dbconfig-common/pgsql/method: unix socket
  dbconfig-common/pgsql/authmethod-user:
  dbconfig-common/upgrade-error: abort
  dbconfig-common/database-type:
  dbconfig-common/dbconfig-remove: true
  dbconfig-common/missing-db-package-error: abort
  dbconfig-common/db/app-user:
  dbconfig-common/pgsql/no-user-choose-other-method:
  dbconfig-common/remote/port:
  dbconfig-common/upgrade-backup: true
  dbconfig-common/purge: false

--- /usr/share/dbconfig-common/internal/pgsql.orig      2010-03-08 
16:31:42.000000000 +0000
+++ /usr/share/dbconfig-common/internal/pgsql   2010-03-08 16:40:10.000000000 
+0000
@@ -129,8 +129,8 @@
        _dbc_psql_cmd_setup
        if [ "$dbc_ssl" ]; then PGSSLMODE="require"; fi
        extra=`_dbc_psql_cmd_args`
-       _dbc_debug "su -s /bin/sh $localuser -c \"env HOME='$_dbc_pgsql_tmpdir' 
PGPASSFILE='$_dbc_pgsql_tmpdir/.pgpass' PGSSLMODE='$PGSSLMODE' dropdb -q $extra 
$*\" 2>&1"
-       dbc_error=`su -s /bin/sh $localuser -c "env HOME='$_dbc_pgsql_tmpdir' 
PGPASSFILE='$_dbc_pgsql_tmpdir/.pgpass' PGSSLMODE='$PGSSLMODE' dropdb -q $extra 
$*" 2>&1` || retval=$?
+       _dbc_debug "su -s /bin/sh $localuser -c \"env HOME='$_dbc_pgsql_tmpdir' 
PGPASSFILE='$_dbc_pgsql_tmpdir/.pgpass' PGSSLMODE='$PGSSLMODE' dropdb $extra 
$*\" 2>&1"
+       dbc_error=`su -s /bin/sh $localuser -c "env HOME='$_dbc_pgsql_tmpdir' 
PGPASSFILE='$_dbc_pgsql_tmpdir/.pgpass' PGSSLMODE='$PGSSLMODE' dropdb $extra 
$*" 2>&1` || retval=$?
        _dbc_psql_cmd_cleanup
        return $retval
 }
@@ -161,8 +161,8 @@
        _dbc_psql_cmd_setup
        if [ "$dbc_ssl" ]; then PGSSLMODE="require"; fi
        extra=`_dbc_psql_cmd_args`
-       _dbc_debug "su -s /bin/sh $localuser -c \"env HOME='$_dbc_pgsql_tmpdir' 
PGPASSFILE='$_dbc_pgsql_tmpdir/.pgpass' PGSSLMODE='$PGSSLMODE' dropuser -q 
$extra $*\" 2>&1"
-       dbc_error=`su -s /bin/sh $localuser -c "env HOME='$_dbc_pgsql_tmpdir' 
PGPASSFILE='$_dbc_pgsql_tmpdir/.pgpass' PGSSLMODE='$PGSSLMODE' dropuser -q 
$extra $*" 2>&1` || retval=$?
+       _dbc_debug "su -s /bin/sh $localuser -c \"env HOME='$_dbc_pgsql_tmpdir' 
PGPASSFILE='$_dbc_pgsql_tmpdir/.pgpass' PGSSLMODE='$PGSSLMODE' dropuser $extra 
$*\" 2>&1"
+       dbc_error=`su -s /bin/sh $localuser -c "env HOME='$_dbc_pgsql_tmpdir' 
PGPASSFILE='$_dbc_pgsql_tmpdir/.pgpass' PGSSLMODE='$PGSSLMODE' dropuser $extra 
$*" 2>&1` || retval=$?
        _dbc_psql_cmd_cleanup
        return $retval
 }