On Thu, 04 Mar 2010, jari wrote: > Running build below. Notice: > > 1. The Makefile's clean target is being run at ">>" > 2. The Makefile is being patches too late at "!!" to > have an effect. > > In this case the "clean" target was off an the patch 05 would have > fixed it, but it didn't have a chance. > > SUGGESTION > > Please apply all the patches before anything else happens to build the > sources.
The documentation is clear, you should have patches applied when you start the build, the fact that it applies them is only a convenience to avoid mistakes: | Note: dpkg-source expects the source tree to have all patches listed in the series | file applied when you generate the source package. This is not the case when the | source tree has been obtained by unpacking a source package using the Format: 1.0 | for instance. To mitigate the problem, dpkg-source will apply the patches by itself | if it believes that they have not yet been applied. To detect this situation, it | uses the following heuristic: it finds the list of supposedly unapplied patches | (they are listed in the series file but not in .pc/applied-patches), and if the | first patch in that set can be applied without errors, it will apply them all. The | option --no-preparation can be used to disable this behaviour. And a freshly unpacked source package in 3.0 (quilt) format will have patches applied so it's a non-issue in the default case. But many people use VCS and don't have patches applied. And even many people would like dpkg-buildpackage to unapply the patches at the end. I was planning to not do anything for this waiting that I get around to implementing vcs-buildpackage to fix up stuff properly. But maybe I should still hack dpkg-buildpackage to call dpkg-source --prepare / dpkg --cleanup and create those 2 commands in dpkg-source. Those commands would also be called even when the source package is not built, just to ensure that all patches have been applied. Cheers, -- Raphaël Hertzog Like what I do? Sponsor me: http://ouaza.com/wp/2010/01/05/5-years-of-freexian/ My Debian goals: http://ouaza.com/wp/2010/01/09/debian-related-goals-for-2010/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
