I'd appreciate it if you could have a look at the code I just uploaded
to unstable, and review it for correctness.  You can see the diff here:

  http://bzr.debian.org/loggerhead/users/cjwatson/makepasswd/trunk/revision/20

I've reviewed the code. The only possible problem I've found is in the line

my $max = 1 << ($bytes * 8);

Theoretically overflow can happen here resulting in zero or negative result and then the program can hang in the loop below this line. But for all reasonable values this line is just fine.

Cheers,
Fyodor Menshikov.




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to