Hi Mikio, I'm the Debian maintainer of Tokyo Tyrant. I received a bug report about error handling. Is this something you think is reasonable to be improved in the upstream version of Tyrant?
Regards, Örjan ----- Forwarded message from Sebastian Harl <[email protected]> ----- Date: Sat, 23 Jan 2010 23:34:50 +0100 From: Sebastian Harl <[email protected]> Reply-To: Sebastian Harl <[email protected]>, [email protected] To: Debian Bug Tracking System <[email protected]> Subject: Bug#566573: tokyotyrant: bad error handling User-Agent: Mutt/1.5.18 (2008-05-17) Package: tokyotyrant Version: 0.9.19-2 Severity: normal Hi, some (most? all?) public functions in tokyotyrant verify their arguments by (ab)using assert(). Thus, any user program passing an invalid argument will abort. That's not a nice thing to do. Also, please note that tokyotyrant is currently built using -DNDEBUG, i.e., assert() will be a no-op. Thus, an invalid argument will probably cause a segfault in most cases, providing no useful information to the user about what might be the source of the problem. I know that it will be quite some work to fix this properly, because upstream seems to rely on that and does not do any/much error checking. So, if upstream does not agree with my POV, feel free to mark this bug 'wontfix'. Cheers, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin ----- End forwarded message -----
signature.asc
Description: Digital signature
