Tom Feiner wrote:
Hi Tim,

Thanks for the bug report. The plugin looks very nice :D

Basically, the right way to get a plugin included in the munin-plugins-extra
package, is to have it accepted by upstream, and it will automatically be
packaged into munin-plugins-extra as part of the contrib family. This way not
only debian users will be able to enjoy the plugin, but all other users in
other distributions.

Regarding the plugin itself, it looks very similar to the netstat plugin.
(although your plugins is more detailed and shows data on fin_wait* and
close_wait.  Have you looked at the netstat plugin? [1] It seems they have
some things in common.

Thanks very much - I hadn't looked at netstat - my motivation for writing the TCP plugin was to reproduce some functionality originally present in Cricket - application bugs which don't properly close TCP connections are quite common, and in fact I needed to know all the states - particularly CLOSE_WAIT.

I didn't know that you drew munin-plugins-extra from upstream - I'd assumed they just came from various sources via the munin plugin database.

I had a quick look at netstat (which parses the output of "/bin/netstat -s"), and it seems like there's a lot of additional info there which could be usefully added...

Thanks,

Tim.

--
South East Open Source Solutions Limited
Registered in England and Wales with company number 06134732. Registered Office: 2 Powell Gardens, Redhill, Surrey, RH1 1TQ
VAT number: 900 6633 53  http://seoss.co.uk/ +44-(0)1273-808309




--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to