On Tue, Jan 12, 2010 at 12:31:35PM +0100, Patrick Schoenfeld wrote: >Severity: grave >Package: libevent >Version: 1.4.13-stable-1 > >Hi, > >I recently took some time to investigate #560550 and noticed >that an undocumented and uncommunicated change in libevent >broke dnsproxy.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=559012 It also caused the breakage of farpd (bug #559012). See bug report above. The attached diff shows how Javier fixed it. The last time dnsproxy was built, it used libevent1_1.3e-3 which isn't available anymore in sid. We now have libevent-1.4-2_1.4.13-stable-1. >Factual the library removed symbols which are used by other >applications when the library is used as documented. It at least hits >event_gotsig and event_sigcb. > >This change is not documented, the manpage event(3) even furthermore >suggests the use of this symbols. I know that a alpha version talks >about deprecation of these symbols, but this can not happen without >communicating this PRIOR the deprecation. > >So now I'm unsure how to go on. Its not documented how to change the >behaviour of a depending program (at least I haven't found such >documentation), nor is the current documentation accurate, nor is the >change at all documented (ChangeLog), nor was I as a maintainer of a >dependent package beeing informed. I would appreciate if you could work >torwards: > >- updating the documentation >- clarifying if that change is really intended >- clarifying what needs to get changed in order to build again I've Cc-ed Nick and Niels for their comments about those three points above. >Thanks and best Regards, >Patrick
debdiff --exclude \*config.guess --exclude \*config.sub farpd_0.2-9.dsc farpd_0.2-10.dsc
diff -Nru --exclude '*config.guess' --exclude '*config.sub' farpd-0.2/arpd.c farpd-0.2/arpd.c
--- farpd-0.2/arpd.c 2010-01-14 20:50:11.000000000 +1100
+++ farpd-0.2/arpd.c 2010-01-14 20:50:11.000000000 +1100
@@ -445,9 +445,6 @@
void
terminate_handler(int sig)
{
- extern int event_gotsig;
-
- event_gotsig = 1;
arpd_sig = sig;
}
@@ -464,7 +461,6 @@
main(int argc, char *argv[])
{
struct event recv_ev;
- extern int (*event_sigcb)(void);
char *dev;
int c, debug;
FILE *fp;
@@ -524,7 +520,6 @@
perror("signal");
return (-1);
}
- event_sigcb = arpd_signal;
event_dispatch();
diff -Nru --exclude '*config.guess' --exclude '*config.sub' farpd-0.2/debian/changelog farpd-0.2/debian/changelog
--- farpd-0.2/debian/changelog 2010-01-14 20:50:11.000000000 +1100
+++ farpd-0.2/debian/changelog 2010-01-14 20:50:11.000000000 +1100
@@ -1,3 +1,12 @@
+farpd (0.2-10) unstable; urgency=low
+
+ * Remove code using event_gotsig and event_sigcb, this external integers
+ are deprecated and no longer defined in newer versions of libevent
+ (Closes: #559012)
+ * Fix LSB header, farpd requires $network and $syslog
+
+ -- Javier Fernandez-Sanguino Pen~a <[email protected]> Thu, 10 Dec 2009 02:38:17 +0100
+
farpd (0.2-9) unstable; urgency=low
* Describe in the manpage known issues with nmap as described in Honeyd's
diff -Nru --exclude '*config.guess' --exclude '*config.sub' farpd-0.2/debian/farpd.init farpd-0.2/debian/farpd.init
--- farpd-0.2/debian/farpd.init 2010-01-14 20:50:11.000000000 +1100
+++ farpd-0.2/debian/farpd.init 2010-01-14 20:50:11.000000000 +1100
@@ -11,8 +11,8 @@
#
### BEGIN INIT INFO
# Provides: farpd
-# Required-Start: networking
-# Required-Stop: networking
+# Required-Start: $network $syslog
+# Required-Stop: $network $syslog
# Default-Start:
# Default-Stop: 0 1 6
# Short-Description: Daemon that replies to any ARP requests
signature.asc
Description: Digital signature
