On Sat, 2010-01-09 at 04:38 +0000, Aníbal Monsalve Salazar wrote: > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=563971 > > rpcbind only enables the -w option if the --enable-warmstarts > option is passed to configure. > > The fact that it does not print a useful error message in this > case is an error. > > Signed-off-by: [email protected] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Errr.... That is nowhere near anything like a valid signoff.
The whole point of a signoff line is to let us know who is contributing the patch, and that the person in question either wrote the patch themselves, or have been given the right to pass it on as an open source patch by the true author. Big NACK until that is fixed. Trond > Tested-by: Anibal Monsalve Salazar <[email protected]> > > --- a/src/rpcbind.c 2010-01-06 16:10:17.000000000 -0500 > +++ b/src/rpcbind.c 2010-01-06 16:09:57.864844553 -0500 > @@ -758,13 +758,18 @@ > case 's': > runasdaemon = 1; > break; > -#ifdef WARMSTART > case 'w': > +#ifdef WARMSTART > warmstart = 1; > break; > -#endif > default: /* error */ > fprintf(stderr, "usage: rpcbind [-adhilsw]\n"); > +#else > + fprintf(stderr, "-w: rpcbind compiled without WARMSTART > support.\n"); > + /* FALLTHROUGH */ > + default: /* error */ > + fprintf(stderr, "usage: rpcbind [-adhils]\n"); > +#endif > exit (1); > } > } > _______________________________________________ > NFSv4 mailing list > [email protected] > http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4 -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
