Subject: timidity-daemon: No error message executing `invoke-rc.d timidity stop` when timidity is not running. Package: timidity-daemon Version: 2.13.2-7.3 Severity: minor
*** Please type your report below this line ***
Dear Debian hackers,
if Timidity is not running
$ ps aux | grep *timidity*
joe 25362 0.0 0.0 3124 812 pts/6 S+ 13:13 0:00 grep
*timidity*
trying to stop Timidity should reflect that.
$ sudo invoke-rc.d timidity stop
Stopping TiMidity++ ALSA midi emulation....
$ echo $?
0
Looking at `/etc/init.d/timidity` the executed command is the following.
start-stop-daemon --stop --quiet --oknodo --pidfile ${PIDFILE} \
--name ${NAME} --retry 10
1. The return value is 0 because `--oknodo` lets s-s-d return 0 »if no
actions are taken« (`man start-stop-daemon`). This seems to be due to
some policy and implemented in #414929 [1].
2. It would be nice if the user could see nevertheless that Timidity did
not run in background. I see two possibilities.
a) Remove `--quiet` as an argument for s-s-d. The formatting of the
output has to be adapted a little.
$ sudo invoke-rc.d timidity stop # `--quiet` removed in script
Stopping TiMidity++ ALSA midi emulation...No timidity found running;
none killed.
.
.
b) Adapt the init script to print an error message as in `libvirt-bin`
[2] which uses a function »running« to check whether the process is
running. But that should be the same behavior as implementing a). I do
not know the reason why “all” other packages call s-s-d with `--quiet`
too.
I guessed the version for the BTS, but it has probably already present
since before fixing [1]. I am running 2.13.2-37 (Sid/unstable).
Thanks,
Paul
[1] http://bugs.debian.org/414929
[2]
http://git.debian.org/?p=pkg-libvirt/libvirt.git;a=blob;f=debian/libvirt-bin.init
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (x86_64)
Kernel: Linux 2.6.32-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages timidity-daemon depends on:
ii adduser 3.112 add and remove users and groups
ii timidity 2.13.2-37 Software sound renderer (MIDI sequ
timidity-daemon recommends no packages.
timidity-daemon suggests no packages.
-- no debconf information
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
