tags 172634 + patch pending
thanks
"jack --submit" does not give any information what's wrong when a
freedb file is invalid. The patch below fixes this.
* Martin Michlmayr <[EMAIL PROTECTED]> [2005-07-28 20:58]:
> * Michael Banck <[EMAIL PROTECTED]> [2005-06-11 12:05]:
> > do you think this is still an issue? Upstream advised me a while
> > ago to close this bug as it should probably be no longer an issue.
>
> No, this is still there.
>
>
> 5796:[EMAIL PROTECTED]: /media/ogg/various/the_mask] jack --submit
> This is jack 3.1.1 (C)2004 Arne Zellentin <[EMAIL PROTECTED]>
> *error* invalid freedb file
> zsh: exit 1 jack --submit
diff -urN jack-3.1.1~/jack_prepare.py jack-3.1.1/jack_prepare.py
--- jack-3.1.1~/jack_prepare.py 2005-07-28 22:31:02.926899488 +0100
+++ jack-3.1.1/jack_prepare.py 2005-07-28 23:12:54.958012712 +0100
@@ -466,7 +466,7 @@
if not is_submittable:
error("can't submit in current state, please fix jack.freedb")
- err, jack_tag.track_names, jack_tag.locale_names, cd_id, revision =
jack_freedb.freedb_names(jack_freedb.freedb_id(jack_ripstuff.all_tracks),
jack_ripstuff.all_tracks, jack_ripstuff.all_tracks, cf['_freedb_form_file'])
+ err, jack_tag.track_names, jack_tag.locale_names, cd_id, revision =
jack_freedb.freedb_names(jack_freedb.freedb_id(jack_ripstuff.all_tracks),
jack_ripstuff.all_tracks, jack_ripstuff.all_tracks, cf['_freedb_form_file'],
verb = 1)
if err:
error("invalid freedb file")
else:
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]