Package: dirvish
Priority: optional
Section: admin
Installed-Size: 244
Maintainer: Paul Slootman <[email protected]>
Architecture: all
Version: 1.2.1-1.1
Depends: libtime-modules-perl, libtime-period-perl, perl, perl-modules,
rsync (>= 2.5.6-0.1)
Recommends: ssh (>= 3.4p1)
Filename: pool/main/d/dirvish/dirvish_1.2.1-1.1_all.deb
Size: 60382
MD5sum: 4094973e3ff46aa9e908c3d7c8a7c351
SHA1: 7d530b3c1690a951decea91bcc7f38f7c53fc519
SHA256: 937ca60aefd760cfbfa4e3ca8b140dda2a2e365e04b82b3ca64da24b199319a6

----------------- snip ----------------


The pre/post clien/server scripts should have access to these
environment variables:

$DIRVISH_CLIENT
$DIRVISH_SERVER
$DIRVISH_SRC
$DIRVISH_DEST

As a script of mine didn't run as expected I checked their validity with:

--- snip ---
tree: /etc
xdev: 0
index: gzip
pre-server: echo $DIRVISH_CLIENT |wall; echo $DIRVISH_SERVER |wall; echo
$DIRVISH_SRC |wall; echo $DIRVISH_DEST |wall;
#pre-client:
#post-client:
#post-server:
--- snip ---


The output was piped to "wall" to immediately show the result. Currently
the result is _empty_ ! Running "set |wall" reveals, that currently all
the DIRVISH variables are put into one single line and are _not_ separated.

--- snip ---
[...]                                          
BASH_EXECUTION_STRING='cd /<some_path>/2009-12-06--05-17-50/tree;
DIRVISH_SERVER=<FQDN> DIRVISH_CLIENT=<FQDN> DIRVISH_SRC=<source_path>
DIRVISH_DEST=/<path>/_test_remote/2009-12-06--05-17-50/tree
DIRVISH_IMAGE=_test_remote:default:2009-12-06--05-17-50 set
|wall;'                                                                         
                                                 

[...]
--- snip ---


It is immediately obvious that there are no ";" between the variables,
so it can't work !

A patch looks like this and works on my system:


---- SNIP ----

--- dirvish.old 2009-11-24 12:47:20.000000000 +0100
+++ dirvish.new 2009-11-24 12:47:07.000000000 +0100
@@ -537,7 +537,7 @@
 $env_srctree = $srctree;               #+SIS:
 $env_srctree =~ s/ /\\ /g;             #+SIS:

-$WRAPPER_ENV = sprintf (" %s=%s" x 5,
+$WRAPPER_ENV = sprintf (" %s=%s;" x 5,
        'DIRVISH_SERVER', $$Options{Server},
        'DIRVISH_CLIENT', $$Options{client},
 #-SIS: 'DIRVISH_SRC', $srctree,

---- SNIP ----


Note the ";" in the sprintf line.


I've posted this to the dirvish mailing list, but it seems to be dead.
Or at least unread/unfrequented.


Robert



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to