Bug#554146: munin-cgi-graph reports errors in HTTP If-Modified-Since check

[Valentin Vidic]

Package: munin
Version: 1.2.6-10~lenny1
Severity: normal


After enabling munin-cgi-graph generator and doing a page reload
apache2 error logs start filling up with with the following error:

[Tue Nov 03 10:10:10 2009] [error] [client 1.2.3.4] Use of uninitialized value 
$ifmodsec in numeric lt (<) at /usr/lib/cgi-bin/munin-cgi-graph line 301., 
referer: http://webhost/domain/host.domain-processor.html

It looks like the parameters passed to modified function are not correct.
I think this is fixed in munin SVN and should be backported to Debian
package.

-- System Information:
Debian Release: 5.0.3
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.30-bpo.1-amd64 (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages munin depends on:
ii  adduser                  3.110           add and remove users and groups
pn  libdigest-md5-perl       <none>          (no description available)
ii  libhtml-template-perl    2.9-1           HTML::Template : A module for usin
ii  libparse-recdescent-perl 1.95.1+dfsg-3   generates recursive-descent parser
ii  librrds-perl             1.3.1-4         Time-series data storage and displ
pn  libstorable-perl         <none>          (no description available)
ii  perl [libtime-hires-perl 5.10.0-19lenny2 Larry Wall's Practical Extraction 
ii  perl-modules             5.10.0-19lenny2 Core Perl modules
ii  rrdtool                  1.3.1-4         Time-series data storage and displ

Versions of packages munin recommends:
ii  libdate-manip-perl       5.54-1          a perl library for manipulating da
ii  munin-node               1.2.6-10~lenny1 network-wide graphing framework (n

Versions of packages munin suggests:
ii  apache2-mpm-prefork [htt 2.2.9-10+lenny4 Apache HTTP Server - traditional n
ii  elinks [www-browser]     0.11.4-3        advanced text-mode WWW browser
ii  links [www-browser]      2.1pre37-1.1    Web browser running in text mode

-- no debconf information

--- ./usr/lib/cgi-bin/munin-cgi-graph   2009-03-13 14:10:05.000000000 +0100
+++ /usr/lib/cgi-bin/munin-cgi-graph    2009-11-03 10:15:12.000000000 +0100
@@ -78,8 +78,7 @@
     my $slast_modified = strftime ("%a, %d %b %Y %H:%M:%S %Z", localtime 
($sstats[9]));
 
     if (defined $ENV{HTTP_IF_MODIFIED_SINCE} and 
-       !&modified (gmtime(time+($period{$scale}-($time%$period{$scale}))),
-                   $sstats[9]-1)) {
+       !&modified ($ENV{HTTP_IF_MODIFIED_SINCE}, $sstats[9]-1)) {
        print "Status: 304\n";
        print "Content-Type: image/png\n";
        print "Expires: ", strftime ("%a, %d %b %Y %H:%M:%S GMT", 
gmtime(time+($period{$scale}-($time%$period{$scale})))), "\n";