Package: kftpgrabber
Version: 0.8.1-2
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu karmic ubuntu-patch
In Ubuntu, we've applied the attached patch to achieve the following:
* Fix FTBFS (LP: #452905):
- 12_const_char_for_eglibc2.10.diff: fix invalid pointer conversion
in kftpgrabber/src/engine/ftpsocket.cpp
We thought you might be interested in doing the same.
The build fails with the following error:
g++ -DHAVE_CONFIG_H -I. -I. -I../../.. -I.. -I./.. -I../misc -I./../misc
-I/usr/include/kde -I/usr/share/qt3/include -I. -DQT_THREAD_SUPPORT
-D_REENTRANT -DNDEBUG -DNO_DEBUG -g -O2 -g -Wall -O2 -DQT_CLEAN_NAMESPACE
-DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -c -o
ftpsocket.o ftpsocket.cpp
ftpsocket.cpp: In member function 'void
KFTPEngine::FtpCommandNegotiateData::negotiateEpsv()':
ftpsocket.cpp:761: error: invalid conversion from 'const char*' to 'char*'
ftpsocket.cpp: In member function 'void
KFTPEngine::FtpCommandNegotiateData::negotiatePasv()':
ftpsocket.cpp:796: error: invalid conversion from 'const char*' to 'char*'
ftpsocket.cpp:800: error: invalid conversion from 'const char*' to 'char*'
ftpsocket.cpp: In member function 'KNetwork::KSocketAddress
KFTPEngine::FtpSocket::setupActiveTransferSocket()':
ftpsocket.cpp:938: warning: suggest parentheses around assignment used as truth
value
make[5]: *** [ftpsocket.o] Error 1
http://launchpadlibrarian.net/31953917/buildlog_ubuntu-karmic-i386.kftpgrabber_0.8.1-2_FAILEDTOBUILD.txt.gz
-- System Information:
Debian Release: 5.0
APT prefers jaunty-updates
APT policy: (500, 'jaunty-updates'), (500, 'jaunty-security'), (500,
'jaunty-proposed'), (500, 'jaunty-backports'), (500, 'jaunty')
Architecture: i386 (i686)
Kernel: Linux 2.6.28-15-generic (SMP w/2 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- kftpgrabber-0.8.1.orig/debian/patches/12_const_char_for_eglibc2.10.diff
+++ kftpgrabber-0.8.1/debian/patches/12_const_char_for_eglibc2.10.diff
@@ -0,0 +1,21 @@
+diff -Nur -x '*.orig' -x '*~' kftpgrabber-0.8.1/kftpgrabber/src/engine/ftpsocket.cpp kftpgrabber-0.8.1.new/kftpgrabber/src/engine/ftpsocket.cpp
+--- kftpgrabber-0.8.1/kftpgrabber/src/engine/ftpsocket.cpp 2007-05-15 22:20:33.000000000 +0400
++++ kftpgrabber-0.8.1.new/kftpgrabber/src/engine/ftpsocket.cpp 2009-10-16 12:41:46.000000000 +0400
+@@ -758,7 +758,7 @@
+ }
+
+ // 229 Entering Extended Passive Mode (|||55016|)
+- char *begin = strchr(socket()->getResponse().ascii(), '(');
++ const char *begin = strchr(socket()->getResponse().ascii(), '(');
+ int port;
+
+ if (!begin || sscanf(begin, "(|||%d|)", &port) != 1) {
+@@ -793,7 +793,7 @@
+
+ // Ok PASV command successfull - let's parse the result
+ int ip[6];
+- char *begin = strchr(socket()->getResponse().ascii(), '(');
++ const char *begin = strchr(socket()->getResponse().ascii(), '(');
+
+ // Some stinky servers don't respect RFC and do it on their own
+ if (!begin)
