Hi,
I'm the Fedora packager for KSensors. I have been asked to apply the patch
Michael Schuele posted here, so I've had a look at it. The patch is indeed
needed to fix coretemp sensors on multi-core or multi-CPU machines getting
mixed up, I have this problem too on my Core 2 Duo notebook. There are,
however, 2 issues I found with it, one trivial, one not so much:
* setDescription takes a const QString &, so there's no need to .latin1()
your QString when passing it there. (I can easily fix this, and yes, I see
the existing code did that in one place, that's a bug. :-) )
* I think doing things this way will require existing users to reconfigure
everything, as it'll change all their sensor IDs. :-( I think it'd be nicer
if we could use the full ID only if the short one is ambiguous, that way
we'd keep existing configuration working as much as possible.
Kevin Kofler
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
