Package: pinball
Version: 0.3.1-8
Severity: minor
Tags: patch
Hi,
the provided .desktop file is not valid (see the result of the
`desktop-file-validate` run).
The attached patch fixes basically almost all the issues:
- the 'Encoding' key is deprecated (removed)
- the 'Application' category is no more useful (removed)
- the 'Categories' key is a list, so it should end with the list separator (';')
- the 'Terminal' key takes a boolean, so the correct value is true/false (0/1
are the deprecated int values)
- also, two empty lines at the end were removed
References:
- http://www.freedesktop.org/wiki/Specifications/desktop-entry-spec
- http://www.freedesktop.org/wiki/Specifications/menu-spec
Thanks,
--
Pino
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (850, 'testing'), (800, 'unstable'), (750, 'experimental'), (750,
'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages pinball depends on:
ii libc6 2.9-25 GNU C Library: Shared libraries
ii libgcc1 1:4.4.1-4 GCC support library
ii libgl1-mesa-glx [libgl1] 7.5.1-1 A free implementation of the OpenG
ii libglu1-mesa [libglu1] 7.5.1-1 The OpenGL utility library (GLU)
ii libice6 2:1.0.5-1 X11 Inter-Client Exchange library
ii libsdl-image1.2 1.2.7-2 image loading library for Simple D
ii libsdl-mixer1.2 1.2.8-6+b1 mixer library for Simple DirectMed
ii libsdl1.2debian 1.2.13-4+b1 Simple DirectMedia Layer
ii libsm6 2:1.1.1-1 X11 Session Management library
ii libstdc++6 4.4.1-4 The GNU Standard C++ Library v3
ii pinball-data 0.3.1-8 Data files for the Emilia Pinball
pinball recommends no packages.
pinball suggests no packages.
-- no debconf information
--- pinball.desktop.orig 2009-10-05 09:26:42.000000000 +0200
+++ pinball.desktop 2009-10-05 09:27:29.000000000 +0200
@@ -1,12 +1,9 @@
[Desktop Entry]
-Encoding=UTF-8
-Categories=Application;Game;ArcadeGame;X-Red-Hat-Extra
+Categories=Game;ArcadeGame;X-Red-Hat-Extra;
X-Desktop-File-Install-Version=0.2
Name=Emilia Pinball
Comment=OpenGL pinball game
Exec=pinball
Icon=pinball.xpm
-Terminal=0
+Terminal=false
Type=Application
-
-
