Package: fslint
Version: 2.40-2
Severity: wishlist
POSIX standard provides the $(...) command substitution syntax, which
improves legibility and allows nested structures. Please consider
applying the attached patch.
References:
POSIX standard IEEE Std 1003.1: 2.6.3 Command Substitution
http://www.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_03
Bash manual: "...old-style backquote" in section "3.5.4 Command
Substitution"
http://www.gnu.org/software/bash/manual/bashref.html#Command-Substitution
BashFAQ: Why is $(...) preferred over `...` (backticks)?
http://mywiki.wooledge.org/BashFAQ/082#head-d13610f7247e7f6dc5eed1b337983b5e509bc409
Advanced Bash-Scripting Guide: "...The $(...) form has
superseded backticks for command substitution."
http://tldp.org/LDP/abs/html/commandsub.html
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages fslint depends on:
ii findutils 4.4.2-1 utilities for finding files--find,
ii python 2.5.4-2 An interactive high-level object-o
ii python-glade2 2.16.0-1 GTK+ bindings: Glade support
ii python-gtk2 2.16.0-1 Python bindings for the GTK+ widge
fslint recommends no packages.
fslint suggests no packages.
-- no debconf information
fslint/findbl | 12 ++++++------
fslint/finded | 6 +++---
fslint/findid | 10 +++++-----
fslint/findnl | 6 +++---
fslint/findns | 12 ++++++------
fslint/findrs | 8 ++++----
fslint/findsn | 14 +++++++-------
fslint/findtf | 8 ++++----
fslint/findu8 | 6 +++---
fslint/findul | 10 +++++-----
fslint/findup | 14 +++++++-------
fslint/fslint | 6 +++---
12 files changed, 56 insertions(+), 56 deletions(-)
diff --git a/fslint/findbl b/fslint/findbl
index b7de0d9..e370dd7 100755
--- a/fslint/findbl
+++ b/fslint/findbl
@@ -47,13 +47,13 @@
# auto tidying of messy links could use tr -s / to squeeze consequtive /'s
# and sed s//..///d to remove /../
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "find \"Bad\" symbolic Links.
Usage: $ProgName [-d] [-s] [-l] [-s] [-n] [[-r] [-f] paths(s) ...]
@@ -67,7 +67,7 @@ These options are mutually exclusive (i.e. only the last one
takes effect).
If no path(s) specified, then the current directory is assumed.
e.g. find dangling links in "library directories":
-findbl \`getffl\`"
+findbl \$(getffl)"
exit
}
@@ -78,7 +78,7 @@ mode="dangling" #default
# " ...", "..." etc. Hmm the symlinks program probably doesn't
# handle this correctly either?
-ASC_01=`printf "\001"`
+ASC_01=$(printf "\001")
for arg
do
@@ -112,7 +112,7 @@ done
. "$script_dir"/supprt/getfpf "$argsToPassOn"
-EPWD=`pwd | sed 's#/#\\\\/#g'`
+EPWD=$(pwd | sed 's#/#\\\\/#g')
case "$mode" in
suspect)
diff --git a/fslint/finded b/fslint/finded
index 4ba0993..331b2d5 100755
--- a/fslint/finded
+++ b/fslint/finded
@@ -14,13 +14,13 @@
# See the GNU General Public License for more details,
# which is available at www.gnu.org
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "find Empty Directory branches.
Usage: $ProgName [[-r] [-f] paths(s) ...]
diff --git a/fslint/findid b/fslint/findid
index 5b4b43d..a1b9cec 100755
--- a/fslint/findid
+++ b/fslint/findid
@@ -14,13 +14,13 @@
# See the GNU General Public License for more details,
# which is available at www.gnu.org
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "find unused or bad file ids
Usage: $ProgName [[-r] [-f] paths(s) ...]
@@ -42,8 +42,8 @@ done
. "$script_dir"/supprt/getfpf "$argsToPassOn"
-reUsers="`cut -f3 -d: /etc/passwd | tr '\n' '|'`0"
-reGroups="`cut -f3 -d: /etc/group | tr '\n' '|'`0"
+reUsers="$(cut -f3 -d: /etc/passwd | tr '\n' '|')0"
+reGroups="$(cut -f3 -d: /etc/group | tr '\n' '|')0"
find "$@" -printf "%U:%G:$FPF\0" |
sort -zu | #merge files (indirectly) specified multiple times
tr '\n\0' '\1\n' |
diff --git a/fslint/findnl b/fslint/findnl
index 54f5a0f..c1f7fb1 100755
--- a/fslint/findnl
+++ b/fslint/findnl
@@ -49,13 +49,13 @@
#is /. This can make things very awkward, especially for future extensions
#like streams etc.
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "find Name (directory or file) Lint.
Usage: $ProgName [-1] [-2] [-3] [-p] [[-r] [-f] paths(s) ...]
diff --git a/fslint/findns b/fslint/findns
index ce43e03..c9b2387 100755
--- a/fslint/findns
+++ b/fslint/findns
@@ -16,19 +16,19 @@
# Notes:
-# Because of limitiation of `file`, files
+# Because of limitiation of $(file), files
# with : in name will not be processed correctly
-# Also note, don't sort by size before `file`
+# Also note, don't sort by size before $(file)
# since there will be more seeking over disk and
# therefore will be much slower.
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "find NonStripped executables.
Usage: $ProgName [[-r] [-f] paths(s) ...]
@@ -38,7 +38,7 @@ If no path(s) specified then the PATH is searched."
if [ $# -eq "0" ] #Nothing on cmdline means search binary directories
then
- eval set -- `. "$script_dir"/supprt/getffp`
+ eval set -- $(. "$script_dir"/supprt/getffp)
FPF="%p"
else
for arg
diff --git a/fslint/findrs b/fslint/findrs
index fe19f5a..eaffa80 100755
--- a/fslint/findrs
+++ b/fslint/findrs
@@ -20,13 +20,13 @@
# Could have option also to flag files that have many consequtive blank lines
# the corresponding regexp would be? "^[ ]*${2,}"
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "find Redundant whiteSpace.
Usage: $ProgName [-w] [-t[#]] [-c] [[-r] [-f] paths(s) ...]
@@ -64,7 +64,7 @@ do
eol_specified="yes" ;;
-t*)
#keep only last 2 digits
- ts=`echo $arg|tr -cd '[:digit:]'|sed 's/^0*//;s/.*\(..\)/\1/'`
+ ts=$(echo $arg|tr -cd '[:digit:]'|sed 's/^0*//;s/.*\(..\)/\1/')
[ -z "$ts" ] && ts=8 #very rare to have larger than this
at_start='^[ ]*'
tabs="$at_start( | {$ts,})" ;;
diff --git a/fslint/findsn b/fslint/findsn
index f80c300..c672d5c 100755
--- a/fslint/findsn
+++ b/fslint/findsn
@@ -35,13 +35,13 @@
# Todo: give option to include directory names & or symbolic links
# Todo: give option to exclude links that point to same file
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "find (files) with duplicate or conflicting names.
Usage: $ProgName [-A -c -C] [[-r] [-f] paths(s) ...]
@@ -72,11 +72,11 @@ fi
if [ $# -eq "0" ]; then #Nothing on cmdline means search $PATH
mode="path"
- eval set -- `. "$script_dir"/supprt/getffp`
+ eval set -- $(. "$script_dir"/supprt/getffp)
FPF="%p"
elif [ $# -eq "1" ] && [ "$1" = "-A" ]; then
mode="aliases"
- eval set -- `. "$script_dir"/supprt/getffp`
+ eval set -- $(. "$script_dir"/supprt/getffp)
FPF="%p"
else
for arg; do
@@ -129,7 +129,7 @@ auto_ignore_paths()
/sbin/lvm.static
" | sed '/ *#/d; /^ *$/d' | #remove comments and blank lines
while read path; do
- inode=`find "$path" -printf "%i" 2>/dev/null`
+ inode=$(find "$path" -printf "%i" 2>/dev/null)
[ "$inode" ] && echo -n " -and ! -inum $inode"
done
}
@@ -152,7 +152,7 @@ matchFilenames)
uniq --all-repeated=$uniqsep -1 $uniq_ignore_case ;;
path)
- find "$@" \( -type f -o -type l \) -follow \( `auto_ignore_paths` \) \
+ find "$@" \( -type f -o -type l \) -follow \( $(auto_ignore_paths) \) \
-printf "$FPF\1%i\1%f\0" |
sort -zu | #merge files (indirectly) specified multiple times
translate safe |
diff --git a/fslint/findtf b/fslint/findtf
index 20146e6..ce044eb 100755
--- a/fslint/findtf
+++ b/fslint/findtf
@@ -14,13 +14,13 @@
# See the GNU General Public License for more details,
# which is available at www.gnu.org
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "find Temporary Files.
Usage: $ProgName [-c] [--age=days] [[-r] [-f] paths(s) ...]
@@ -45,7 +45,7 @@ do
-v|--version)
Version ;;
--age=*)
- days=`echo $arg | cut -b7-`
+ days=$(echo $arg | cut -b7-)
[ "$days" ] && MIN_AGE=$days ;;
-c)
core_mode="yes" ;;
diff --git a/fslint/findu8 b/fslint/findu8
index b436b72..ff743c0 100755
--- a/fslint/findu8
+++ b/fslint/findu8
@@ -20,13 +20,13 @@
# This is slow as it starts an iconv process per file,
# but it mitigates this by filtering out ascii only names beforehand.
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "find names with invalid UTF8 encoding.
Usage: $ProgName [[-r] [-f] paths(s) ...]
diff --git a/fslint/findul b/fslint/findul
index a6cfea8..41756fe 100755
--- a/fslint/findul
+++ b/fslint/findul
@@ -14,13 +14,13 @@
# See the GNU General Public License for more details,
# which is available at www.gnu.org
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "Find possible redundant (Unused) Libraries.
Usage: $ProgName
@@ -54,7 +54,7 @@ done
# let's remove this file, just in case it's a symlink pointing to
# /lib/ld-linux.so.2 or something...
rm -f "$TMP/all_libs"
-lib_dirs=`. "$script_dir"/supprt/getffl`
+lib_dirs=$(. "$script_dir"/supprt/getffl)
find $lib_dirs -type f -follow -name '*.so*' -printf '%p\t%i\n' |
sort -k2,2n |
uniq -f1 > "$TMP/all_libs"
@@ -62,7 +62,7 @@ uniq -f1 > "$TMP/all_libs"
# let's remove this file, just in case it's a symlink pointing to
# /lib/ld-linux.so.2 or something...
rm -f "$TMP/all_used_libs"
-find `. "$script_dir"/supprt/getffp` -xdev -type f -perm +111 |
+find $(. "$script_dir"/supprt/getffp) -xdev -type f -perm +111 |
xargs ldd |
cut -s -f3 -d' ' |
grep -F / |
diff --git a/fslint/findup b/fslint/findup
index 1e06eeb..0b60c80 100755
--- a/fslint/findup
+++ b/fslint/findup
@@ -54,13 +54,13 @@
# symbolic links are ignored.
# path1 & path2 can be files &/or directories
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "find dUPlicate files.
Usage: $ProgName [[[-t [-m|-d]] | [--summary]] [-r] [-f] paths(s) ...]
@@ -88,13 +88,13 @@ search for duplicates in /usr/bin
search in multiple directories but not their subdirectories
findup -r /usr/bin /bin /usr/sbin /sbin
search for duplicates in \$PATH
- findup \`"$script_dir"/supprt/getffp\`
+ findup \$("$script_dir"/supprt/getffp)
search system for duplicate files over 100K in size
findup / -size +100k
search only my files (that I own and are in my home dir)
- findup ~ -user \`id -u\`
+ findup ~ -user \$(id -u)
search system for duplicate files belonging to roger
- findup / -user \`id -u roger\`"
+ findup / -user \$(id -u roger)"
exit
}
@@ -209,7 +209,7 @@ if [ "$mode" ]; then
declare -i counter #Use bash arithmetic, not expr (for speed)
counter=0
while read; do
- # We note we don't specify "file" to `read`
+ # We note we don't specify "file" to read
# or else trailing IFS will be stripped
file="$REPLY"
if [ ! "$file" ]; then
diff --git a/fslint/fslint b/fslint/fslint
index 9c19e8f..427cf01 100755
--- a/fslint/fslint
+++ b/fslint/fslint
@@ -20,13 +20,13 @@
# This is just a simple wrapper for the various commands.
# This assumes all commands are in same dir.
-script_dir=`dirname "$0"` #directory of this script
-script_dir=`readlink -f "$script_dir"` #Make sure absolute path
+script_dir=$(dirname "$0") #directory of this script
+script_dir=$(readlink -f "$script_dir") #Make sure absolute path
. "$script_dir"/supprt/fslver
Usage() {
- ProgName=`basename "$0"`
+ ProgName=$(basename "$0")
echo "File system lint.
A collection of utilities to find lint on a filesystem.
To get more info on each utility run 'util --help'.
