On Sat, Sep 12, 2009 at 04:15:48PM +0100, Bradley Smith wrote:
> Gah sorry, I misread the bug report..
>
1) The problem seem to appear because
ioctl(i8k_fd, I8K_BIOS_VERSION, &args))
return value is less then 0.
$ grep -A2 I8K_BIOS_VERSION i8kutils-1.32/i8kctl.c
if ((rc=ioctl(i8k_fd, I8K_BIOS_VERSION, &args)) < 0) {
return NULL;
}
What makes an ioctl call return less then 0?
Perhaps i8kutils-1.32/i8kctl.c should be patched to print errno to
stderr?
2) Is it related to the fact that the author states there are bugs:
$ grep -A1 I8K_BIOS_VERSION i8kutils-1.32/i8k.h
#define I8K_BIOS_VERSION _IOR ('i', 0x80, int) /* broken:
meant 4 bytes */
#define I8K_MACHINE_ID _IOR ('i', 0x81, int) /* broken:
meant 16 bytes */
?
Is fixing this problem is a matter of just fixing
i8kutils-1.32/i8k.h, or should the kernel module be fixed?
--
[email protected]
SDF Public Access UNIX System - http://sdf.lonestar.org
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
