On Mon, Sep 14, 2009 at 11:25:22PM -0700, Steve Langasek wrote: > On Tue, Sep 15, 2009 at 07:51:00AM +0200, Roland Clobus wrote: > > I still think that this bug report now contains two bugs reports: > > 1) Fixing playing games with localhost (especially for computer players) > > 2) Making the server IPv6 compliant > > > No 1. is fixed, and that fix alone should be enough to make a new > > release. > > It would be nice if no 2. would be fixed, but that can be done slightly > > later. > > Except that you've fixed #1 in a manner which is redundant if #2 were fixed > properly.
There may be weird routing problems which result in a port being shown as listening, but unable to accept connections. Especially because the meta-server get the port to advertise from the server, not from probing.[1] So IMO it is good to keep the "try all options"-loop, even if it should never be needed in properly configured networks. Thanks, Bas [1] Which is something we should eventually fix as well. The meta-server should simply use getpeername() on the socket that connects to it. No extra network traffic is required.
signature.asc
Description: Digital signature
