Hi!

On Thu, 2009-08-20 at 21:10:30 +0200, Petter Reinholdtsen wrote:
> Package:  xfstt
> Version:  1.7-2
> Severity: important
> Tags:     patch
> User:     [email protected]
> Usertags: incorrect-provides incorrect-dependency
> 
> With dependency based boot sequencing, I discovered what I believe is
> a bug in the init.d script.  The provides used should be unique, and
> the current one is in conflict with the xfs package.

> To avoid surprises when xdm no longer find its xfs
> dependency when xfstt is installed, I recommend adding reverse
> dependencies on xdm, and all the other *dm alternatives.

Couldn't we define a new virtual facility for xfs? There's been other
font servers in the past in Debian, and having to modify all DM
packages to add new font servers or keep track of new DM to add to
the font server packages do not seem optimal.

Could such a new virtual facility use the same name as xfs, or do they
share the namespace?

> Also, the script need files in /usr/, and should depend on $remote_fs.

Ok.

> The script used to start after the syslog service was available, and
> probably should keep doing so.

The daemon does not use syslog (yet), so I've not merged this part.

> This patch should solve the issue.  Without it, the package will fail
> to install if xfs was installed previously.

> diff -ur xfstt-1.7/debian/init.d xfstt-1.7-pere/debian/init.d
> --- xfstt-1.7/debian/init.d     2009-08-20 21:02:16.000000000 +0200
> +++ xfstt-1.7-pere/debian/init.d        2009-08-20 21:03:52.000000000 +0200
> @@ -1,11 +1,10 @@
>  #!/bin/sh
>  #
>  ### BEGIN INIT INFO
> -# Provides:          xfs xfstt
> -# Required-Start:    $local_fs $network
> -# Required-Stop:     $local_fs $network
> -# Should-Start:
> -# Should-Stop:
> +# Provides:          xfstt
> +# Required-Start:    $local_fs $network $remote_fs $syslog
> +# Required-Stop:     $local_fs $network $remote_fs $syslog
> +# X-Start-Before:    gdm kdm xdm ldm sdm
>  # Default-Start:     2 3 4 5
>  # Default-Stop:      0 1 6
>  # Short-Description: xfstt sysv init script

Thanks, (partially) applied and will be on next upload.

regards,
guillem



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to