Package: dhcp-probe Version: 1.3.0-1 Severity: important Tags: patch User: [email protected] Usertags: incorrect-runlevels incorrect-dependency
With dependency based boot sequencing, I discovered what I believe is a bug in the init.d script. The script uses files in /usr/ and should depend on $remote_fs, not $local_fs. Also, the $networking virtual facility do not exist. I suspect you wanted the $network facility instead. Last, and more seriously, the script is not set up to stop in runlevel 1, and this will create problems when switching to and from runlevel 1. This will bring the runlevel list in line with the argument used for update-rc.d. <URL: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html > documents the LSB header format. Some debian notes are available from <URL: http://wiki.debian.org/LSBInitScripts >. This patch should solve the issue. Because the script already depend on $syslog, this change will not affect the boot ordering, but only make the stated dependencies make more sense. Without the runlevel change, the service will not start as it should when switching from runlevel 1 to 2-5. In addition to this header change, some code in postinst is needed to add the stop symlink in rc1.d during upgrades. diff -ur dhcp-probe-1.3.0/debian/dhcp-probe.init.d dhcp-probe-1.3.0-pere/debian/dhcp-probe.init.d --- dhcp-probe-1.3.0/debian/dhcp-probe.init.d 2009-08-19 09:34:23.000000000 +0200 +++ dhcp-probe-1.3.0-pere/debian/dhcp-probe.init.d 2009-08-19 09:34:55.000000000 +0200 @@ -1,10 +1,10 @@ #!/bin/sh ### BEGIN INIT INFO # Provides: dhcp-probe -# Required-Start: $networking $syslog -# Required-Stop: $networking $syslog +# Required-Start: $remote_fs $network $syslog +# Required-Stop: $remote_fs $network $syslog # Default-Start: 2 3 4 5 -# Default-Stop: 0 6 +# Default-Stop: 0 1 6 # Short-Description: dhcp-probe daemon to survey DHCP/BootP server on LAN ### END INIT INFO Happy hacking, -- Petter Reinholdtsen -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
