tags 534138 confirmed
thanks

On Mon, 22 Jun 2009 02:07:31 +0200, Cyril Brulebois wrote:

> Heya,

Hello KiBi,

> [Initially, was:
> Subject: wicd: Please don't propose additions to netdev if not relevant
> Severity: minor
> ]

ACK.

> I guess you may want to filter out users that are already in the netdev
> group.

Sure, that can be done. But then, how to handle removal of users? Or maybe this
shouldn't be the scope of my debconf screen.

> As for my system, got two users, cyril & guest, the former being in the
> netdev group already, and both were proposed as “Users to add to the netdev
> group”.
> 
> But, looking at the code:
> | # Add users not there yet
> | for u in $users; do
> |         adduser $u netdev
> |         netdev=$(echo $netdev | sed -e "s...@$u@@g")
> | done
> | 
> | # Remove users, present in the group, but not chosen in debconf
> | for u in $netdev; do
> |         deluser $u netdev
> | done
> 
> So you:
>  - fail to detect people already in the netdev group.

This was tried in the first version to experimental, but EPICFAIL :)

db_metaget wicd/users default
db_subst wicd/users default "$(getent group netdev | cut -d: -f4 | sed 's@,@,
@g')"

And this caused #532112 (${default} wasn't substituted in the templates file)

>  - advertise you're going to add some users to that group.

Sure, that's what it actually does, if you check the users :)

>  - actually remove people that previously were there (because the local
>    admin may not want to check boxes for users that are known to already
>    be in the right group).

Ok, I clearly see where my debian/config fails (→ confirmed).
I will try to really fix what caused #532112, or only propose users for
addition (i.e. don't handle removals).

> That shouldn't migrate to testing in this shape, IMHO.

That's why I uploaded that to experimental, before moving it to sid. But it
seems that not all debconf-related bugs were spot.

Thank you for filing the bug,
David

-- 
 . ''`.  Debian maintainer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Attachment: signature.asc
Description: PGP signature

Reply via email to