On Fri, Jun 19, 2009 at 09:23:27AM +0200, Vincent Fourmond wrote: > On Fri, Jun 19, 2009 at 9:17 AM, Ryan Niebur<[email protected]> wrote: > > svn-buildpackage's autodetection can't be perfect, if it fails for > > your repository you can set svn props to override the search. > > changing the behavior of this to not look for ../tags if the direction > > is not trunk could very easily break somebody's (wacky) setup, so I > > wouldn't want to do this. > > There is one way around, though: the order in which the directories > are tried could depend on whether the current directory finishes with > trunk/ or not. If yes, then try ../tags first. If no, then try > ../../tags/package first ?
This doesn't sound very sane either. There is always the possibility of breaking anyone's repository structure. Simply imagine someone who has more than the package structure checked in that repository and has (for whatever reason) a tags directory in this structure. Sure, it's a rare case and probably less likely than yours but it's still possible. svn://domain.tld/tags svn://domain.tld/package/trunk and looking for ../../tags is broken as well. > > since you are no longer affected by this would you be ok with me just > > closing the bug? what do the other contributors to svn-bp think? > > I did downgrade this as a wishlist bug. I'd like to keep it open, > and if that's fine by you, I'll provide a patch for that within a few > days (say, Sunday). I would also consider this a bug to keep it open. It's not really a wishlist bug but rather a minor bug, but I don't care about semantics here. :) FWIW, one (or even the) goal of the svn-bp branch I recently started is to reliably detect repository structures and form proper URLs out of that. It will need some changes to svn-bp but in the end it'll solve bugs like this one. You can still provide a patch for the current version though, as I'm not sure when I'm done with my work. Maybe can have a bugfix release again in a few weeks. Cheers, Hauke
signature.asc
Description: Digital signature
