Package: exaile
Version: 0.2.11.1+debian-2
Severity: normal
Tag: patch
Due to the security issue pointed out in Bug #451303 downloading plugins
has been disabled. Yet, Exaile still checks for updates. If we disable
downloading updates, we shouldn't throw pop-ups at the user telling them
to download the updates. Attached is a patch against
debian/patches/000-Do_not_download_remote_plugins.diff that disables all
update checking and removes the option to check for updates from the
Preferences GUI.
Thanks!
- Andrew Starr-Bochicchio
diff -u exaile-0.2.14+debian/debian/patches/000-Do_not_download_remote_plugins.diff exaile-0.2.14+debian/debian/patches/000-Do_not_download_remote_plugins.diff
--- exaile-0.2.14+debian/debian/patches/000-Do_not_download_remote_plugins.diff
+++ exaile-0.2.14+debian/debian/patches/000-Do_not_download_remote_plugins.diff
@@ -64,0 +68,60 @@
+Index: exaile-0.2.14+debian/exaile.glade
+===================================================================
+--- exaile-0.2.14+debian.orig/exaile.glade 2009-06-06 19:20:40.828698673 -0400
++++ exaile-0.2.14+debian/exaile.glade 2009-06-06 19:21:50.463696324 -0400
+@@ -4663,25 +4663,6 @@
+ </child>
+
+ <child>
+- <widget class="GtkCheckButton" id="prefs_check_for_updates">
+- <property name="visible">True</property>
+- <property name="can_focus">True</property>
+- <property name="label" translatable="yes">Automatically check for Exaile and plugin updates</property>
+- <property name="use_underline">True</property>
+- <property name="relief">GTK_RELIEF_NORMAL</property>
+- <property name="focus_on_click">True</property>
+- <property name="active">False</property>
+- <property name="inconsistent">False</property>
+- <property name="draw_indicator">True</property>
+- </widget>
+- <packing>
+- <property name="padding">0</property>
+- <property name="expand">False</property>
+- <property name="fill">False</property>
+- </packing>
+- </child>
+-
+- <child>
+ <widget class="GtkHBox" id="hbox32">
+ <property name="visible">True</property>
+ <property name="homogeneous">False</property>
+Index: exaile-0.2.14+debian/xl/gui/main.py
+===================================================================
+--- exaile-0.2.14+debian.orig/xl/gui/main.py 2009-06-06 19:20:40.896695324 -0400
++++ exaile-0.2.14+debian/xl/gui/main.py 2009-06-06 19:21:50.463696324 -0400
+@@ -170,9 +170,9 @@
+ self.urlhandlers = []
+
+ # check for updates
+- if self.settings.get_boolean('check_for_updates', True):
+- self.playlist_manager.connect('last-playlist-loaded',
+- start_updatecheck_thread)
++ #if self.settings.get_boolean('check_for_updates', True):
++ # self.playlist_manager.connect('last-playlist-loaded',
++ # start_updatecheck_thread)
+
+ if self.settings.get_boolean("ui/use_splash", True):
+ image = gtk.Image()
+Index: exaile-0.2.14+debian/xl/prefs.py
+===================================================================
+--- exaile-0.2.14+debian.orig/xl/prefs.py 2009-06-06 19:21:58.591695297 -0400
++++ exaile-0.2.14+debian/xl/prefs.py 2009-06-06 19:22:06.123701330 -0400
+@@ -530,7 +530,7 @@
+ 'replaygain/album_mode': (CheckPrefsItem, True),
+ 'replaygain/preamp': (FloatPrefsItem, 0.0),
+ 'replaygain/fallback': (FloatPrefsItem, 0.0),
+- 'check_for_updates': (CheckPrefsItem, True),
++ #'check_for_updates': (CheckPrefsItem, True),
+ 'proxy/enabled': (CheckPrefsItem, False, None, self.proxy_setting_changed),
+ 'proxy/server': (PrefsItem, '', None, self.proxy_setting_changed),
+ 'proxy/port': (PrefsItem, '', None, self.proxy_setting_changed),
