clone 528647 -1
reassign -1 debhelper
block 528647 with -1
thanks
On Thu, 14 May 2009 12:12:24 +0100, Bradley Smith wrote:
> Whilst building your package on AVR32, the build failed with:
> Malformed argument '--skipdeps' at
> /usr/share/perl/5.10/Module/Build/Compat.pm line 170.
Gna.
This is my fault: Joey was kind enough to add '--skipdeps' to
debhelper's dh_auto_configure on my request (cf. #528235).
I've tested it with Makefile.PL from ExtUtils::MakeMaker and from
Module::Install but not with Module::Build::Compat, and here it seems
to break.
I guess '--skipdeps' should only be added if
inc/Module/Install/AutoInstall.pm really exists. I'm attaching a
preliminary and untested patch as a suggestion.
(Another question is if we can add "create_packlist=0" only if
Makefile.PL uses M::B::C; it doesn't break anything in other cases
but the warning we get is not particularly nice either.)
Sorry for the mess ...
gregor
--
.''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4
: :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/
`. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
`- Dammit Jim, I'm an actor, not a doctor.
--- dh_auto_configure.orig 2009-05-14 13:36:15.000000000 +0200
+++ dh_auto_configure 2009-05-14 13:49:55.000000000 +0200
@@ -66,9 +66,9 @@
error("could not find Source: line in control file.");
}
+my @opts;
if (-x "configure") {
# Standard set of options for configure.
- my @opts;
push @opts, "--build=".dpkg_architecture_value("DEB_BUILD_GNU_TYPE");
push @opts, "--prefix=/usr";
push @opts, "--includedir=\${prefix}/include";
@@ -89,15 +89,20 @@
}
elsif (-e "Makefile.PL") {
# If set to a true value then MakeMaker's prompt function will
- # # always return the default without waiting for user input.
+ # always return the default without waiting for user input.
$ENV{PERL_MM_USE_DEFAULT}=1;
- doit("perl", "Makefile.PL", "INSTALLDIRS=vendor",
- "create_packlist=0", "--skipdeps", @{$dh{U_PARAMS}});
+ push @opts, "INSTALLDIRS=vendor";
+ # for Module::Build::Compat
+ push @opts, "create_packlist=0"; # detect M::B::C?
+ # for Module::Install
+ push @opts, "--skipdeps" if (-e "inc/Module/Install/AutoInstall.pm");
+ doit("perl", "Makefile.PL", @opts, @{$dh{U_PARAMS}});
}
elsif (-e "Build.PL") {
$ENV{PERL_MM_USE_DEFAULT}=1; # Module::Build can also use this.
$ENV{MODULEBUILDRC} = "/dev/null";
- doit("perl", "Build.PL", "installdirs=vendor", @{$dh{U_PARAMS}});
+ push @opts, "installdirs=vendor";
+ doit("perl", "Build.PL", @opts, @{$dh{U_PARAMS}});
}
=head1 SEE ALSO
