Bug#522227: mailformat variable should not be initialized

[Franck Joncourt]

Package: debarchiver
Version: 0.9.2
Severity: normal

Hi Ola,

I was using debarchiver and I encountered a problem with the mailformat
variable.

At the beginning of debarchiver I had set:

$mailformat = "sendmail"

and thus if people do not define $usermailcmd in their config file, they
get the following error:

--
The mailformat option must be used in conjunction to the mailcmd option
--

due to this:

[quote=debarchiver]
if ( ($mailformat ne "") && ($usermailcmd eq "") ) {
    errormsg...

} elsif ($mailformat eq "sendmail") {
    @mailsearch = ("sendmail", "mail");

} elsif ($mailformat eq "mail") {
    @mailsearch = ("mail", "sendmail");

} else {
    error_msg...
}
[/quote]

I have enclosed a patch which should fix the problem.

What do you think?

Sorry :(

-- 
Franck Joncourt
http://debian.org - http://smhteam.info/wiki/

diff --git a/src/debarchiver.pl b/src/debarchiver.pl
index efa3797..ce3cf0a 100755
--- a/src/debarchiver.pl
+++ b/src/debarchiver.pl
@@ -76,7 +76,7 @@ use OpaL::read qw(readfile readcommand);
 #  2009-03-16 Franck Joncourt <franck.m...@dthconnex.com>
 #       Added usermailcmd, mailsearch, usermailcmd and cmds. Removed mailcmd.
 
-$mailformat    = "sendmail";
+$mailformat    = "";
 @mailsearch    = ();
 $usermailcmd   = '';
 
@@ -2554,7 +2554,7 @@ sub  check_mailconfig()
     if ( ($mailformat ne "") && ($usermailcmd eq "") ) {
         pdebug(2, "The mailformat option must be used in conjunction to the mailcmd option.");
 
-    } elsif ($mailformat eq "sendmail") {
+    } elsif ( ($mailformat eq "sendmail") || ($mailformat eq "") ) {
         @mailsearch = ("sendmail", "mail");
 
     } elsif ($mailformat eq "mail") {

signature.asc
Description: OpenPGP digital signature