Bug#520440: poppler: some header files causes gcc warnings

[Jakub Wilk]

Package: libpoppler-dev
Version: 0.10.4-3
Severity: minor
Inclusion of some poppler header files causes gcc to emit dozens of 
warnings. See [1] for an example build log.

Poppler build system suppresses those warnings with -Wno-write-strings. 
I could, of course, use that option too. However, I don't want to 
conceal potential bugs in my own code.

The attached patch fixes the symptoms in <poppler/Object.h>.

[1] 
https://buildd.debian.org/fetch.cgi?&pkg=pdf2djvu&ver=0.4.11a-1%2Bb1&arch=i386&stamp=1236513697&file=log

--
Jakub Wilk
diff --git a/poppler/Object.h b/poppler/Object.h
--- a/poppler/Object.h
+++ b/poppler/Object.h
@@ -46,14 +46,14 @@
 
 #define OBJECT_TYPE_CHECK(wanted_type) \
     if (unlikely(type != wanted_type)) { \
-        error(0, "Call to Object where the object was type %d, " \
+        error(0, (char*) "Call to Object where the object was type %d, " \
                  "not the expected type %d", type, wanted_type); \
         abort(); \
     }
 
 #define OBJECT_2TYPES_CHECK(wanted_type1, wanted_type2) \
     if (unlikely(type != wanted_type1) && unlikely(type != wanted_type2)) { \
-        error(0, "Call to Object where the object was type %d, " \
+        error(0, (char*) "Call to Object where the object was type %d, " \
                  "not the expected type %d or %d", type, wanted_type1, wanted_type2); \
         abort(); \
     }